threads / patch / 40330

patchtag, update-ref: improve description of option "create-reflog"

Subject: [PATCH] tag, update-ref: improve description of option "create-reflog"

## tl;dr

3 messages between Sep 11, 2015 and Sep 12, 2015. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ralf Thielow· Sep 11, 2015, 16:04 UTC · lore

The description of option "create-reflog" is "create_reflog", which is neither a good description, nor a sensible string to translate. Change it to a more meaningful message.

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
 builtin/tag.c        | 2 +-
 builtin/update-ref.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Show changes to 2 files +2 −2

builtin/tag.c, builtin/update-ref.c

diff --git a/builtin/tag.c b/builtin/tag.c
index cccca99..cba0e22 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 		OPT_STRING('u', "local-user", &keyid, N_("key-id"),
 					N_("use another key to sign the tag")),
 		OPT__FORCE(&force, N_("replace the tag if exists")),
-		OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")),
+		OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")),
 
 		OPT_GROUP(N_("Tag listing options")),
 		OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")),
diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index 04dd00f..7f30d3a 100644
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c
@@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
 					N_("update <refname> not the one it points to")),
 		OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")),
 		OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")),
-		OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")),
+		OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")),
 		OPT_END(),
 	};

-- 
2.6.0.rc1.199.g678474c

Junio C Hamano· Sep 11, 2015, 16:47 UTC · re: Ralf Thielow · lore

Re: [PATCH] tag, update-ref: improve description of option "create-reflog"

Ralf Thielow <ralf.thielow@gmail.com> writes:

Show 6 quoted lines

> The description of option "create-reflog" is "create_reflog", which
> is neither a good description, nor a sensible string to translate.
> Change it to a more meaningful message.
>
> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
> ---

This definitely is an improvement. I will assume i18n team is OK with a change like this this late in the cycle (I see you CC'ed Jiang) and will merge before the next -rc.

Thanks.

Show 29 quoted lines

>  builtin/tag.c        | 2 +-
>  builtin/update-ref.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/tag.c b/builtin/tag.c
> index cccca99..cba0e22 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
>  		OPT_STRING('u', "local-user", &keyid, N_("key-id"),
>  					N_("use another key to sign the tag")),
>  		OPT__FORCE(&force, N_("replace the tag if exists")),
> -		OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")),
> +		OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")),
>  
>  		OPT_GROUP(N_("Tag listing options")),
>  		OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")),
> diff --git a/builtin/update-ref.c b/builtin/update-ref.c
> index 04dd00f..7f30d3a 100644
> --- a/builtin/update-ref.c
> +++ b/builtin/update-ref.c
> @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
>  					N_("update <refname> not the one it points to")),
>  		OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")),
>  		OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")),
> -		OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")),
> +		OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")),
>  		OPT_END(),
>  	};

Jiang Xin· Sep 12, 2015, 15:07 UTC · re: Junio C Hamano · lore

Re: [PATCH] tag, update-ref: improve description of option "create-reflog"

2015-09-12 0:47 GMT+08:00 Junio C Hamano <gitster@pobox.com>:

Show 13 quoted lines

> Ralf Thielow <ralf.thielow@gmail.com> writes:
>
>> The description of option "create-reflog" is "create_reflog", which
>> is neither a good description, nor a sensible string to translate.
>> Change it to a more meaningful message.
>>
>> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
>> ---
>
> This definitely is an improvement.  I will assume i18n team is OK
> with a change like this this late in the cycle (I see you CC'ed
> Jiang) and will merge before the next -rc.
>

Agree. Those who have already finished this round of l10n (including sv (Swedish) and vi (Vietnamese)) should update their translations for this update.

Show 31 quoted lines

> Thanks.
>
>>  builtin/tag.c        | 2 +-
>>  builtin/update-ref.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/builtin/tag.c b/builtin/tag.c
>> index cccca99..cba0e22 100644
>> --- a/builtin/tag.c
>> +++ b/builtin/tag.c
>> @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
>>               OPT_STRING('u', "local-user", &keyid, N_("key-id"),
>>                                       N_("use another key to sign the tag")),
>>               OPT__FORCE(&force, N_("replace the tag if exists")),
>> -             OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")),
>> +             OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")),
>>
>>               OPT_GROUP(N_("Tag listing options")),
>>               OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")),
>> diff --git a/builtin/update-ref.c b/builtin/update-ref.c
>> index 04dd00f..7f30d3a 100644
>> --- a/builtin/update-ref.c
>> +++ b/builtin/update-ref.c
>> @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
>>                                       N_("update <refname> not the one it points to")),
>>               OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")),
>>               OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")),
>> -             OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")),
>> +             OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")),
>>               OPT_END(),
>>       };

-- 
Jiang Xin