# [PATCH] tag, update-ref: improve description of option "create-reflog" 3 messages from 2015-09-11 to 2015-09-12. Participants: Ralf Thielow, Junio C Hamano, Jiang Xin. Thread: https://gitlist.dev/t/40330 ## Ralf Thielow, 2015-09-11 16:04 Subject: [PATCH] tag, update-ref: improve description of option "create-reflog" Message-ID: <1441987453-22125-1-git-send-email-ralf.thielow@gmail.com> URL: https://gitlist.dev/e/1441987453-22125-1-git-send-email-ralf.thielow%40gmail.com ``` The description of option "create-reflog" is "create_reflog", which is neither a good description, nor a sensible string to translate. Change it to a more meaningful message. Signed-off-by: Ralf Thielow --- builtin/tag.c | 2 +- builtin/update-ref.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c index cccca99..cba0e22 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix) OPT_STRING('u', "local-user", &keyid, N_("key-id"), N_("use another key to sign the tag")), OPT__FORCE(&force, N_("replace the tag if exists")), - OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")), + OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")), OPT_GROUP(N_("Tag listing options")), OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")), diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 04dd00f..7f30d3a 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix) N_("update not the one it points to")), OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")), OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")), - OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")), + OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")), OPT_END(), }; -- 2.6.0.rc1.199.g678474c ``` ## Junio C Hamano, 2015-09-11 16:47 Subject: Re: [PATCH] tag, update-ref: improve description of option "create-reflog" Message-ID: URL: https://gitlist.dev/e/xmqq613g2990.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1441987453-22125-1-git-send-email-ralf.thielow@gmail.com> ``` Ralf Thielow writes: > The description of option "create-reflog" is "create_reflog", which > is neither a good description, nor a sensible string to translate. > Change it to a more meaningful message. > > Signed-off-by: Ralf Thielow > --- This definitely is an improvement. I will assume i18n team is OK with a change like this this late in the cycle (I see you CC'ed Jiang) and will merge before the next -rc. Thanks. > builtin/tag.c | 2 +- > builtin/update-ref.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin/tag.c b/builtin/tag.c > index cccca99..cba0e22 100644 > --- a/builtin/tag.c > +++ b/builtin/tag.c > @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix) > OPT_STRING('u', "local-user", &keyid, N_("key-id"), > N_("use another key to sign the tag")), > OPT__FORCE(&force, N_("replace the tag if exists")), > - OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")), > + OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")), > > OPT_GROUP(N_("Tag listing options")), > OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")), > diff --git a/builtin/update-ref.c b/builtin/update-ref.c > index 04dd00f..7f30d3a 100644 > --- a/builtin/update-ref.c > +++ b/builtin/update-ref.c > @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix) > N_("update not the one it points to")), > OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")), > OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")), > - OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")), > + OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")), > OPT_END(), > }; ``` ## Jiang Xin, 2015-09-12 15:07 Subject: Re: [PATCH] tag, update-ref: improve description of option "create-reflog" Message-ID: URL: https://gitlist.dev/e/CANYiYbHcmHuvmDmu9aCKiQ20BiPHGj%3D%3D75BR_x5yscnpFubkdA%40mail.gmail.com In-Reply-To: ``` 2015-09-12 0:47 GMT+08:00 Junio C Hamano : > Ralf Thielow writes: > >> The description of option "create-reflog" is "create_reflog", which >> is neither a good description, nor a sensible string to translate. >> Change it to a more meaningful message. >> >> Signed-off-by: Ralf Thielow >> --- > > This definitely is an improvement. I will assume i18n team is OK > with a change like this this late in the cycle (I see you CC'ed > Jiang) and will merge before the next -rc. > Agree. Those who have already finished this round of l10n (including sv (Swedish) and vi (Vietnamese)) should update their translations for this update. > Thanks. > >> builtin/tag.c | 2 +- >> builtin/update-ref.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/builtin/tag.c b/builtin/tag.c >> index cccca99..cba0e22 100644 >> --- a/builtin/tag.c >> +++ b/builtin/tag.c >> @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix) >> OPT_STRING('u', "local-user", &keyid, N_("key-id"), >> N_("use another key to sign the tag")), >> OPT__FORCE(&force, N_("replace the tag if exists")), >> - OPT_BOOL(0, "create-reflog", &create_reflog, N_("create_reflog")), >> + OPT_BOOL(0, "create-reflog", &create_reflog, N_("create a reflog")), >> >> OPT_GROUP(N_("Tag listing options")), >> OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")), >> diff --git a/builtin/update-ref.c b/builtin/update-ref.c >> index 04dd00f..7f30d3a 100644 >> --- a/builtin/update-ref.c >> +++ b/builtin/update-ref.c >> @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix) >> N_("update not the one it points to")), >> OPT_BOOL('z', NULL, &end_null, N_("stdin has NUL-terminated arguments")), >> OPT_BOOL( 0 , "stdin", &read_stdin, N_("read updates from stdin")), >> - OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create_reflog")), >> + OPT_BOOL( 0 , "create-reflog", &create_reflog, N_("create a reflog")), >> OPT_END(), >> }; -- Jiang Xin ```