{"thread":{"id":"40330","subject":"[PATCH] tag, update-ref: improve description of option \"create-reflog\"","startedAt":"2015-09-11T16:04:13Z","lastAt":"2015-09-12T15:07:10Z","messageCount":3,"participants":["Ralf Thielow","Junio C Hamano","Jiang Xin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"269776","messageId":"1441987453-22125-1-git-send-email-ralf.thielow@gmail.com","threadId":"40330","inReplyTo":null,"subject":"[PATCH] tag, update-ref: improve description of option \"create-reflog\"","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@gmail.com","sentAt":"2015-09-11T16:04:13Z","receivedAt":"2015-09-11T16:04:13Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"The description of option \"create-reflog\" is \"create_reflog\", which\nis neither a good description, nor a sensible string to translate.\nChange it to a more meaningful message.\n\nSigned-off-by: Ralf Thielow \n---\n builtin/tag.c | 2 +-\n builtin/update-ref.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/tag.c b/builtin/tag.c\nindex cccca99..cba0e22 100644\n--- a/builtin/tag.c\n+++ b/builtin/tag.c\n@@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)\n \t\tOPT_STRING('u', \"local-user\", &keyid, N_(\"key-id\"),\n \t\t\t\t\tN_(\"use another key to sign the tag\")),\n \t\tOPT__FORCE(&force, N_(\"replace the tag if exists\")),\n-\t\tOPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n+\t\tOPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n \n \t\tOPT_GROUP(N_(\"Tag listing options\")),\n \t\tOPT_COLUMN(0, \"column\", &colopts, N_(\"show tag list in columns\")),\ndiff --git a/builtin/update-ref.c b/builtin/update-ref.c\nindex 04dd00f..7f30d3a 100644\n--- a/builtin/update-ref.c\n+++ b/builtin/update-ref.c\n@@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)\n \t\t\t\t\tN_(\"update not the one it points to\")),\n \t\tOPT_BOOL('z', NULL, &end_null, N_(\"stdin has NUL-terminated arguments\")),\n \t\tOPT_BOOL( 0 , \"stdin\", &read_stdin, N_(\"read updates from stdin\")),\n-\t\tOPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n+\t\tOPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n \t\tOPT_END(),\n \t};\n \n-- \n2.6.0.rc1.199.g678474c\n"},{"id":"269781","messageId":"xmqq613g2990.fsf@gitster.mtv.corp.google.com","threadId":"40330","inReplyTo":"1441987453-22125-1-git-send-email-ralf.thielow@gmail.com","subject":"Re: [PATCH] tag, update-ref: improve description of option \"create-reflog\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-09-11T16:47:39Z","receivedAt":"2015-09-11T16:47:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ralf Thielow writes:\n\n> The description of option \"create-reflog\" is \"create_reflog\", which\n> is neither a good description, nor a sensible string to translate.\n> Change it to a more meaningful message.\n>\n> Signed-off-by: Ralf Thielow \n> ---\n\nThis definitely is an improvement. I will assume i18n team is OK\nwith a change like this this late in the cycle (I see you CC'ed\nJiang) and will merge before the next -rc.\n\nThanks.\n\n> builtin/tag.c | 2 +-\n> builtin/update-ref.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/tag.c b/builtin/tag.c\n> index cccca99..cba0e22 100644\n> --- a/builtin/tag.c\n> +++ b/builtin/tag.c\n> @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)\n> \t\tOPT_STRING('u', \"local-user\", &keyid, N_(\"key-id\"),\n> \t\t\t\t\tN_(\"use another key to sign the tag\")),\n> \t\tOPT__FORCE(&force, N_(\"replace the tag if exists\")),\n> -\t\tOPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n> +\t\tOPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n> \n> \t\tOPT_GROUP(N_(\"Tag listing options\")),\n> \t\tOPT_COLUMN(0, \"column\", &colopts, N_(\"show tag list in columns\")),\n> diff --git a/builtin/update-ref.c b/builtin/update-ref.c\n> index 04dd00f..7f30d3a 100644\n> --- a/builtin/update-ref.c\n> +++ b/builtin/update-ref.c\n> @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)\n> \t\t\t\t\tN_(\"update not the one it points to\")),\n> \t\tOPT_BOOL('z', NULL, &end_null, N_(\"stdin has NUL-terminated arguments\")),\n> \t\tOPT_BOOL( 0 , \"stdin\", &read_stdin, N_(\"read updates from stdin\")),\n> -\t\tOPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n> +\t\tOPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n> \t\tOPT_END(),\n> \t};\n"},{"id":"269829","messageId":"CANYiYbHcmHuvmDmu9aCKiQ20BiPHGj==75BR_x5yscnpFubkdA@mail.gmail.com","threadId":"40330","inReplyTo":"xmqq613g2990.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] tag, update-ref: improve description of option \"create-reflog\"","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2015-09-12T15:07:10Z","receivedAt":"2015-09-12T15:07:10Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"2015-09-12 0:47 GMT+08:00 Junio C Hamano :\n> Ralf Thielow writes:\n>\n>> The description of option \"create-reflog\" is \"create_reflog\", which\n>> is neither a good description, nor a sensible string to translate.\n>> Change it to a more meaningful message.\n>>\n>> Signed-off-by: Ralf Thielow \n>> ---\n>\n> This definitely is an improvement. I will assume i18n team is OK\n> with a change like this this late in the cycle (I see you CC'ed\n> Jiang) and will merge before the next -rc.\n>\n\nAgree. Those who have already finished this round of l10n\n(including sv (Swedish) and vi (Vietnamese)) should update\ntheir translations for this update.\n\n\n> Thanks.\n>\n>> builtin/tag.c | 2 +-\n>> builtin/update-ref.c | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/builtin/tag.c b/builtin/tag.c\n>> index cccca99..cba0e22 100644\n>> --- a/builtin/tag.c\n>> +++ b/builtin/tag.c\n>> @@ -606,7 +606,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)\n>> OPT_STRING('u', \"local-user\", &keyid, N_(\"key-id\"),\n>> N_(\"use another key to sign the tag\")),\n>> OPT__FORCE(&force, N_(\"replace the tag if exists\")),\n>> - OPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n>> + OPT_BOOL(0, \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n>>\n>> OPT_GROUP(N_(\"Tag listing options\")),\n>> OPT_COLUMN(0, \"column\", &colopts, N_(\"show tag list in columns\")),\n>> diff --git a/builtin/update-ref.c b/builtin/update-ref.c\n>> index 04dd00f..7f30d3a 100644\n>> --- a/builtin/update-ref.c\n>> +++ b/builtin/update-ref.c\n>> @@ -365,7 +365,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)\n>> N_(\"update not the one it points to\")),\n>> OPT_BOOL('z', NULL, &end_null, N_(\"stdin has NUL-terminated arguments\")),\n>> OPT_BOOL( 0 , \"stdin\", &read_stdin, N_(\"read updates from stdin\")),\n>> - OPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create_reflog\")),\n>> + OPT_BOOL( 0 , \"create-reflog\", &create_reflog, N_(\"create a reflog\")),\n>> OPT_END(),\n>> };\n\n\n\n-- \nJiang Xin\n"}]}