threads / discuss / 39940

Indenting lines starting with "die" in shell after "||"

Subject: Indenting lines starting with "die" in shell after "||"

## tl;dr

2 messages between Jul 27, 2015 and Jul 27, 2015.

replies: 1people: 2as markdown or json

Christian Couder· Jul 27, 2015, 09:20 UTC · lore

Hi,

It looks like we are very inconsistent in shell scripts about indenting lines starting with "die" after a line that ends with "||", like:

quite long command || die "command failed"

For example in git-rebase--interactive.sh, there is often, but not always, an extra tab before the die.

It looks like there are no rules about that in Documentation/CodingGuidelines.

Also emacs in shell-script mode is reluctant to add a tab in front of "die" in such a case.

I wonder if we should state a preference for no extra tab in Documentation/CodingGuidelines.

Thanks, Christian.

Johannes Schindelin· Jul 27, 2015, 10:25 UTC · re: Christian Couder · lore

Re: Indenting lines starting with "die" in shell after "||"

Hi Christian,

On 2015-07-27 11:20, Christian Couder wrote:

Show 9 quoted lines

> It looks like we are very inconsistent in shell scripts about
> indenting lines starting with "die" after a line that ends with "||",
> like:
> 
> quite long command ||
> die "command failed"
> 
> For example in git-rebase--interactive.sh, there is often, but not
> always, an extra tab before the die.

That is most likely my fault: I used to add that extra tab. It appears to me as if the convention in Git (and in my current coding style) is not to add an extra tab.

Ciao, Dscho