{"thread":{"id":"39940","subject":"Indenting lines starting with \"die\" in shell after \"||\"","startedAt":"2015-07-27T09:20:00Z","lastAt":"2015-07-27T10:25:35Z","messageCount":2,"participants":["Christian Couder","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"266818","messageId":"CAP8UFD3UmrmREa8hN=jGNM8FMc3XHOyX9hGjfRDej_qMrNsaXw@mail.gmail.com","threadId":"39940","inReplyTo":null,"subject":"Indenting lines starting with \"die\" in shell after \"||\"","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2015-07-27T09:20:00Z","receivedAt":"2015-07-27T09:20:00Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi,\n\nIt looks like we are very inconsistent in shell scripts about\nindenting lines starting with \"die\" after a line that ends with \"||\",\nlike:\n\nquite long command ||\ndie \"command failed\"\n\nFor example in git-rebase--interactive.sh, there is often, but not\nalways, an extra tab before the die.\n\nIt looks like there are no rules about that in Documentation/CodingGuidelines.\n\nAlso emacs in shell-script mode is reluctant to add a tab in front of\n\"die\" in such a case.\n\nI wonder if we should state a preference for no extra tab in\nDocumentation/CodingGuidelines.\n\nThanks,\nChristian.\n"},{"id":"266820","messageId":"847c822062707efaf2171b5568e00e45@www.dscho.org","threadId":"39940","inReplyTo":"CAP8UFD3UmrmREa8hN=jGNM8FMc3XHOyX9hGjfRDej_qMrNsaXw@mail.gmail.com","subject":"Re: Indenting lines starting with \"die\" in shell after \"||\"","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2015-07-27T10:25:35Z","receivedAt":"2015-07-27T10:25:35Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Christian,\n\nOn 2015-07-27 11:20, Christian Couder wrote:\n\n> It looks like we are very inconsistent in shell scripts about\n> indenting lines starting with \"die\" after a line that ends with \"||\",\n> like:\n> \n> quite long command ||\n> die \"command failed\"\n> \n> For example in git-rebase--interactive.sh, there is often, but not\n> always, an extra tab before the die.\n\nThat is most likely my fault: I used to add that extra tab. It appears to me as if the convention in Git (and in my current coding style) is not to add an extra tab.\n\nCiao,\nDscho\n"}]}