git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Indenting lines starting with "die" in shell after "||"

From
Christian Couder <christian.couder@gmail.com>
Date
Jul 27, 2015, 09:20 UTC
Message-ID
<CAP8UFD3UmrmREa8hN=jGNM8FMc3XHOyX9hGjfRDej_qMrNsaXw@mail.gmail.com>
Hi,

It looks like we are very inconsistent in shell scripts about indenting lines starting with "die" after a line that ends with "||", like:

quite long command || die "command failed"

For example in git-rebase--interactive.sh, there is often, but not always, an extra tab before the die.

It looks like there are no rules about that in Documentation/CodingGuidelines.

Also emacs in shell-script mode is reluctant to add a tab in front of "die" in such a case.

I wonder if we should state a preference for no extra tab in Documentation/CodingGuidelines.

Thanks, Christian.

Next: Johannes Schindelin
Message 1 of 2 in “Indenting lines starting with "die" in shell after "||"”
  1. Christian CouderJul 27, 2015
  2. Johannes SchindelinJul 27, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.