threads / patch / 39721

patchblame: remove obsolete comment

Subject: [PATCH] blame: remove obsolete comment

## tl;dr

One message between Jun 25, 2015 and Jun 25, 2015. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nguyễn Thái Ngọc Duy· Jun 25, 2015, 11:08 UTC · lore

That "someday" in the comment happened two years later in b65982b (Optimize "diff-index --cached" using cache-tree - 2009-05-20)

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/blame.c | 5 -----
 1 file changed, 5 deletions(-)
Show changes to builtin/blame.c +0 −5
diff --git a/builtin/blame.c b/builtin/blame.c
index b3e948e..b077bb6 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2371,11 +2371,6 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
 	ce->ce_mode = create_ce_mode(mode);
 	add_cache_entry(ce, ADD_CACHE_OK_TO_ADD|ADD_CACHE_OK_TO_REPLACE);
 
-	/*
-	 * We are not going to write this out, so this does not matter
-	 * right now, but someday we might optimize diff-index --cached
-	 * with cache-tree information.
-	 */
 	cache_tree_invalidate_path(&the_index, path);
 
 	return commit;
-- 
2.3.0.rc1.137.g477eb31

← back to recent threads