{"thread":{"id":"39721","subject":"[PATCH] blame: remove obsolete comment","startedAt":"2015-06-25T11:08:14Z","lastAt":"2015-06-25T11:08:14Z","messageCount":1,"participants":["Nguyễn Thái Ngọc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"264829","messageId":"1435230494-7030-1-git-send-email-pclouds@gmail.com","threadId":"39721","inReplyTo":null,"subject":"[PATCH] blame: remove obsolete comment","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2015-06-25T11:08:14Z","receivedAt":"2015-06-25T11:08:14Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"That \"someday\" in the comment happened two years later in\nb65982b (Optimize \"diff-index --cached\" using cache-tree - 2009-05-20)\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n builtin/blame.c | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/builtin/blame.c b/builtin/blame.c\nindex b3e948e..b077bb6 100644\n--- a/builtin/blame.c\n+++ b/builtin/blame.c\n@@ -2371,11 +2371,6 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,\n \tce->ce_mode = create_ce_mode(mode);\n \tadd_cache_entry(ce, ADD_CACHE_OK_TO_ADD|ADD_CACHE_OK_TO_REPLACE);\n \n-\t/*\n-\t * We are not going to write this out, so this does not matter\n-\t * right now, but someday we might optimize diff-index --cached\n-\t * with cache-tree information.\n-\t */\n \tcache_tree_invalidate_path(&the_index, path);\n \n \treturn commit;\n-- \n2.3.0.rc1.137.g477eb31\n"}]}