git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] blame: remove obsolete comment

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jun 25, 2015, 11:08 UTC
Message-ID
<1435230494-7030-1-git-send-email-pclouds@gmail.com>

That "someday" in the comment happened two years later in b65982b (Optimize "diff-index --cached" using cache-tree - 2009-05-20)

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/blame.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index b3e948e..b077bb6 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2371,11 +2371,6 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
 	ce->ce_mode = create_ce_mode(mode);
 	add_cache_entry(ce, ADD_CACHE_OK_TO_ADD|ADD_CACHE_OK_TO_REPLACE);
 
-	/*
-	 * We are not going to write this out, so this does not matter
-	 * right now, but someday we might optimize diff-index --cached
-	 * with cache-tree information.
-	 */
 	cache_tree_invalidate_path(&the_index, path);
 
 	return commit;
-- 
2.3.0.rc1.137.g477eb31
Message 1 of 1 in “blame: remove obsolete comment”
  1. blame: remove obsolete commentNguyễn Thái Ngọc Duy, Jun 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.