threads / discuss / 3876

[WISH] prepend diffstat in front of the patch

Subject: [WISH] prepend diffstat in front of the patch

## tl;dr

7 messages between Apr 15, 2006 and Apr 15, 2006.

replies: 6people: 3as markdown or json

Marco Costalba· Apr 15, 2006, 09:07 UTC · lore

>From today git tree

$ git-diff-tree -r -c -p --stat 84981f9
84981f9ad963f050abf4fe33ac07d36b4ea90c6d
---
 diff.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

$ git-diff-tree -r -c --stat -p 84981f9 84981f9ad963f050abf4fe33ac07d36b4ea90c6d

diff --git a/diff.c b/diff.c
index c120239..f1b672d 100644
--- a/diff.c
+++ b/diff.c
@@ -438,8 +438,8 @@ static void builtin_diffstat(const char
                xdemitcb_t ecb;

                xpp.flags = XDF_NEED_MINIMAL;
-               xecfg.ctxlen = 3;
-               xecfg.flags = XDL_EMIT_FUNCNAMES;
+               xecfg.ctxlen = 0;
+               xecfg.flags = 0;
                ecb.outf = xdiff_outf;
                ecb.priv = diffstat;
                xdl_diff(&mf1, &mf2, &xpp, &xecfg, &ecb);


Perhaps I missed something, but I would like to see --stat and -p as 
_cumulative_ options .

Would be great if git-diff-tree -r -c --stat -p 84981f9 prepends
diffstat in front of the patch as Junio suggested some days ago.

Is it already planned?

Thanks
Marco

Junio C Hamano· Apr 15, 2006, 09:16 UTC · re: Marco Costalba · lore

Re: [WISH] prepend diffstat in front of the patch

"Marco Costalba" <mcostalba@gmail.com> writes:

> Perhaps I missed something, but I would like to see --stat and -p as 
> _cumulative_ options .

Yes, you missed my write-up on "Recent unresolved issues", especially this entry:

    * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net>
      diff --with-raw, --with-stat? (me)

and the thread that introduced the --stat option.

It is also what I want, but there is only 24 hours in a day and there is this thing called day-job.

Marco Costalba· Apr 15, 2006, 09:23 UTC · re: Junio C Hamano · lore

Re: [WISH] prepend diffstat in front of the patch

On 4/15/06, Junio C Hamano <junkio@cox.net> wrote:

Show 16 quoted lines

> "Marco Costalba" <mcostalba@gmail.com> writes:
>
> > Perhaps I missed something, but I would like to see --stat and -p as
> > _cumulative_ options .
>
> Yes, you missed my write-up on "Recent unresolved issues",
> especially this entry:
>
>     * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net>
>       diff --with-raw, --with-stat? (me)
>
> and the thread that introduced the --stat option.
>
> It is also what I want, but there is only 24 hours in a day and
> there is this thing called day-job.
>

Sorry, I  didn't mean to force anything, just asking.

Day-job thing is not unknown to me too.

Marco

Johannes Schindelin· Apr 15, 2006, 11:51 UTC · re: Junio C Hamano · lore

Re: [WISH] prepend diffstat in front of the patch

Hi,

On Sat, 15 Apr 2006, Junio C Hamano wrote:

> [... speaking about --patch-with-stat ...]
> 
> It is also what I want, but there is only 24 hours in a day and
> there is this thing called day-job.

I want to add that there is a real life also, and that in a few parts of this lovely world, there is Easter right now.

And most importantly: an itch like that is a great opportunity for non-veterans to get involved with git.

Ciao, Dscho

Johannes Schindelin· Apr 15, 2006, 11:48 UTC · re: Marco Costalba · lore

Re: [WISH] prepend diffstat in front of the patch

Hi,

On Sat, 15 Apr 2006, Marco Costalba wrote:

Show 7 quoted lines

> Perhaps I missed something, but I would like to see --stat and -p as 
> _cumulative_ options .
> 
> Would be great if git-diff-tree -r -c --stat -p 84981f9 prepends
> diffstat in front of the patch as Junio suggested some days ago.
> 
> Is it already planned?

We are a little impatient, aren't we?

Anyway, as you probably saw already, I sent out a patch which does that. I wanted to wait a little to introduce it, because I had the feeling that the option parsing would be volatile for a few days.

Ciao, Dscho

Junio C Hamano· Apr 15, 2006, 12:12 UTC · re: Johannes Schindelin · lore

Re: [WISH] prepend diffstat in front of the patch

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Anyway, as you probably saw already, I sent out a patch which does that. I 
> wanted to wait a little to introduce it, because I had the feeling that 
> the option parsing would be volatile for a few days.

Thanks for the consideration, but that's what topic branches are for ;-).

Seriously, even the unified one (either Linus's or mine) handed diff option parsing to an established function that is identical to the "master" version, so the --patch-with-stat is probably a no-impact merge.

		JC "What's Easter" Hamano ;-)

Johannes Schindelin· Apr 15, 2006, 12:30 UTC · re: Junio C Hamano · lore

Re: [WISH] prepend diffstat in front of the patch

Hi,

On Sat, 15 Apr 2006, Junio C Hamano wrote:

> 		JC "What's Easter" Hamano ;-)

Just for the record: According to Douglas Adams, nearly two thousand years ago, one man has been nailed to a tree for saying how great it would be to be nice to people for a change. That's what Christians try to remember on Easter.

Ciao, Dscho