{"thread":{"id":"3876","subject":"[WISH] prepend diffstat in front of the patch","startedAt":"2006-04-15T09:07:40Z","lastAt":"2006-04-15T12:30:45Z","messageCount":7,"participants":["Marco Costalba","Junio C Hamano","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"18683","messageId":"e5bfff550604150207h6fdb0042x3a9bbfa63269a8c8@mail.gmail.com","threadId":"3876","inReplyTo":null,"subject":"[WISH] prepend diffstat in front of the patch","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-04-15T09:07:40Z","receivedAt":"2006-04-15T09:07:40Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":">From today git tree\n\n$ git-diff-tree -r -c -p --stat 84981f9\n84981f9ad963f050abf4fe33ac07d36b4ea90c6d\n---\n diff.c | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\n\n$ git-diff-tree -r -c --stat -p 84981f9\n84981f9ad963f050abf4fe33ac07d36b4ea90c6d\ndiff --git a/diff.c b/diff.c\nindex c120239..f1b672d 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -438,8 +438,8 @@ static void builtin_diffstat(const char\n xdemitcb_t ecb;\n\n xpp.flags = XDF_NEED_MINIMAL;\n- xecfg.ctxlen = 3;\n- xecfg.flags = XDL_EMIT_FUNCNAMES;\n+ xecfg.ctxlen = 0;\n+ xecfg.flags = 0;\n ecb.outf = xdiff_outf;\n ecb.priv = diffstat;\n xdl_diff(&mf1, &mf2, &xpp, &xecfg, &ecb);\n\n\nPerhaps I missed something, but I would like to see --stat and -p as \n_cumulative_ options .\n\nWould be great if git-diff-tree -r -c --stat -p 84981f9 prepends\ndiffstat in front of the patch as Junio suggested some days ago.\n\nIs it already planned?\n\nThanks\nMarco\n"},{"id":"18684","messageId":"7vejzzi4ft.fsf@assigned-by-dhcp.cox.net","threadId":"3876","inReplyTo":"e5bfff550604150207h6fdb0042x3a9bbfa63269a8c8@mail.gmail.com","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-04-15T09:16:54Z","receivedAt":"2006-04-15T09:16:54Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Marco Costalba\" writes:\n\n> Perhaps I missed something, but I would like to see --stat and -p as \n> _cumulative_ options .\n\nYes, you missed my write-up on \"Recent unresolved issues\",\nespecially this entry:\n\n * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net>\n diff --with-raw, --with-stat? (me)\n\nand the thread that introduced the --stat option.\n\nIt is also what I want, but there is only 24 hours in a day and\nthere is this thing called day-job.\n"},{"id":"18685","messageId":"e5bfff550604150223i1ceaee5am9d3ec30f34166c01@mail.gmail.com","threadId":"3876","inReplyTo":"7vejzzi4ft.fsf@assigned-by-dhcp.cox.net","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2006-04-15T09:23:56Z","receivedAt":"2006-04-15T09:23:56Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 4/15/06, Junio C Hamano wrote:\n> \"Marco Costalba\" writes:\n>\n> > Perhaps I missed something, but I would like to see --stat and -p as\n> > _cumulative_ options .\n>\n> Yes, you missed my write-up on \"Recent unresolved issues\",\n> especially this entry:\n>\n> * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net>\n> diff --with-raw, --with-stat? (me)\n>\n> and the thread that introduced the --stat option.\n>\n> It is also what I want, but there is only 24 hours in a day and\n> there is this thing called day-job.\n>\n\nSorry, I didn't mean to force anything, just asking.\n\nDay-job thing is not unknown to me too.\n\nMarco\n"},{"id":"18689","messageId":"Pine.LNX.4.63.0604151346270.25269@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"3876","inReplyTo":"e5bfff550604150207h6fdb0042x3a9bbfa63269a8c8@mail.gmail.com","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-04-15T11:48:49Z","receivedAt":"2006-04-15T11:48:49Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 15 Apr 2006, Marco Costalba wrote:\n\n> Perhaps I missed something, but I would like to see --stat and -p as \n> _cumulative_ options .\n> \n> Would be great if git-diff-tree -r -c --stat -p 84981f9 prepends\n> diffstat in front of the patch as Junio suggested some days ago.\n> \n> Is it already planned?\n\nWe are a little impatient, aren't we?\n\nAnyway, as you probably saw already, I sent out a patch which does that. I \nwanted to wait a little to introduce it, because I had the feeling that \nthe option parsing would be volatile for a few days.\n\nCiao,\nDscho\n"},{"id":"18691","messageId":"Pine.LNX.4.63.0604151349070.25269@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"3876","inReplyTo":"7vejzzi4ft.fsf@assigned-by-dhcp.cox.net","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-04-15T11:51:33Z","receivedAt":"2006-04-15T11:51:33Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 15 Apr 2006, Junio C Hamano wrote:\n\n> [... speaking about --patch-with-stat ...]\n> \n> It is also what I want, but there is only 24 hours in a day and\n> there is this thing called day-job.\n\nI want to add that there is a real life also, and that in a few parts of \nthis lovely world, there is Easter right now.\n\nAnd most importantly: an itch like that is a great opportunity for \nnon-veterans to get involved with git.\n\nCiao,\nDscho\n"},{"id":"18694","messageId":"7vfykfghqs.fsf@assigned-by-dhcp.cox.net","threadId":"3876","inReplyTo":"Pine.LNX.4.63.0604151346270.25269@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-04-15T12:12:27Z","receivedAt":"2006-04-15T12:12:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Anyway, as you probably saw already, I sent out a patch which does that. I \n> wanted to wait a little to introduce it, because I had the feeling that \n> the option parsing would be volatile for a few days.\n\nThanks for the consideration, but that's what topic branches are\nfor ;-).\n\nSeriously, even the unified one (either Linus's or mine) handed\ndiff option parsing to an established function that is identical\nto the \"master\" version, so the --patch-with-stat is probably a\nno-impact merge.\n\n\t\tJC \"What's Easter\" Hamano ;-)\n"},{"id":"18695","messageId":"Pine.LNX.4.63.0604151429110.5914@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"3876","inReplyTo":"7vfykfghqs.fsf@assigned-by-dhcp.cox.net","subject":"Re: [WISH] prepend diffstat in front of the patch","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-04-15T12:30:45Z","receivedAt":"2006-04-15T12:30:45Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Sat, 15 Apr 2006, Junio C Hamano wrote:\n\n> \t\tJC \"What's Easter\" Hamano ;-)\n\nJust for the record: According to Douglas Adams, nearly two thousand years \nago, one man has been nailed to a tree for saying how great it would be to \nbe nice to people for a change. That's what Christians try to remember on \nEaster.\n\nCiao,\nDscho\n"}]}