# [WISH] prepend diffstat in front of the patch 7 messages from 2006-04-15 to 2006-04-15. Participants: Marco Costalba, Junio C Hamano, Johannes Schindelin. Thread: https://gitlist.dev/t/3876 ## Marco Costalba, 2006-04-15 09:07 Subject: [WISH] prepend diffstat in front of the patch Message-ID: URL: https://gitlist.dev/e/e5bfff550604150207h6fdb0042x3a9bbfa63269a8c8%40mail.gmail.com ``` >From today git tree $ git-diff-tree -r -c -p --stat 84981f9 84981f9ad963f050abf4fe33ac07d36b4ea90c6d --- diff.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) $ git-diff-tree -r -c --stat -p 84981f9 84981f9ad963f050abf4fe33ac07d36b4ea90c6d diff --git a/diff.c b/diff.c index c120239..f1b672d 100644 --- a/diff.c +++ b/diff.c @@ -438,8 +438,8 @@ static void builtin_diffstat(const char xdemitcb_t ecb; xpp.flags = XDF_NEED_MINIMAL; - xecfg.ctxlen = 3; - xecfg.flags = XDL_EMIT_FUNCNAMES; + xecfg.ctxlen = 0; + xecfg.flags = 0; ecb.outf = xdiff_outf; ecb.priv = diffstat; xdl_diff(&mf1, &mf2, &xpp, &xecfg, &ecb); Perhaps I missed something, but I would like to see --stat and -p as _cumulative_ options . Would be great if git-diff-tree -r -c --stat -p 84981f9 prepends diffstat in front of the patch as Junio suggested some days ago. Is it already planned? Thanks Marco ``` ## Junio C Hamano, 2006-04-15 09:16 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: <7vejzzi4ft.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vejzzi4ft.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` "Marco Costalba" writes: > Perhaps I missed something, but I would like to see --stat and -p as > _cumulative_ options . Yes, you missed my write-up on "Recent unresolved issues", especially this entry: * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net> diff --with-raw, --with-stat? (me) and the thread that introduced the --stat option. It is also what I want, but there is only 24 hours in a day and there is this thing called day-job. ``` ## Marco Costalba, 2006-04-15 09:23 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: URL: https://gitlist.dev/e/e5bfff550604150223i1ceaee5am9d3ec30f34166c01%40mail.gmail.com In-Reply-To: <7vejzzi4ft.fsf@assigned-by-dhcp.cox.net> ``` On 4/15/06, Junio C Hamano wrote: > "Marco Costalba" writes: > > > Perhaps I missed something, but I would like to see --stat and -p as > > _cumulative_ options . > > Yes, you missed my write-up on "Recent unresolved issues", > especially this entry: > > * Message-ID: <7vek02ynif.fsf@assigned-by-dhcp.cox.net> > diff --with-raw, --with-stat? (me) > > and the thread that introduced the --stat option. > > It is also what I want, but there is only 24 hours in a day and > there is this thing called day-job. > Sorry, I didn't mean to force anything, just asking. Day-job thing is not unknown to me too. Marco ``` ## Johannes Schindelin, 2006-04-15 11:48 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0604151346270.25269%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: ``` Hi, On Sat, 15 Apr 2006, Marco Costalba wrote: > Perhaps I missed something, but I would like to see --stat and -p as > _cumulative_ options . > > Would be great if git-diff-tree -r -c --stat -p 84981f9 prepends > diffstat in front of the patch as Junio suggested some days ago. > > Is it already planned? We are a little impatient, aren't we? Anyway, as you probably saw already, I sent out a patch which does that. I wanted to wait a little to introduce it, because I had the feeling that the option parsing would be volatile for a few days. Ciao, Dscho ``` ## Johannes Schindelin, 2006-04-15 11:51 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0604151349070.25269%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <7vejzzi4ft.fsf@assigned-by-dhcp.cox.net> ``` Hi, On Sat, 15 Apr 2006, Junio C Hamano wrote: > [... speaking about --patch-with-stat ...] > > It is also what I want, but there is only 24 hours in a day and > there is this thing called day-job. I want to add that there is a real life also, and that in a few parts of this lovely world, there is Easter right now. And most importantly: an itch like that is a great opportunity for non-veterans to get involved with git. Ciao, Dscho ``` ## Junio C Hamano, 2006-04-15 12:12 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: <7vfykfghqs.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vfykfghqs.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Johannes Schindelin writes: > Anyway, as you probably saw already, I sent out a patch which does that. I > wanted to wait a little to introduce it, because I had the feeling that > the option parsing would be volatile for a few days. Thanks for the consideration, but that's what topic branches are for ;-). Seriously, even the unified one (either Linus's or mine) handed diff option parsing to an established function that is identical to the "master" version, so the --patch-with-stat is probably a no-impact merge. JC "What's Easter" Hamano ;-) ``` ## Johannes Schindelin, 2006-04-15 12:30 Subject: Re: [WISH] prepend diffstat in front of the patch Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0604151429110.5914%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <7vfykfghqs.fsf@assigned-by-dhcp.cox.net> ``` Hi, On Sat, 15 Apr 2006, Junio C Hamano wrote: > JC "What's Easter" Hamano ;-) Just for the record: According to Douglas Adams, nearly two thousand years ago, one man has been nailed to a tree for saying how great it would be to be nice to people for a change. That's what Christians try to remember on Easter. Ciao, Dscho ```