[PATCH] imap-send.c: support GIT_CURL_VERBOSE

Kyle J. McKay· Jan 6, 2015, 11:00 UTC · lore

When using git-imap-send to send via cURL, support setting the GIT_CURL_VERBOSE environment variable to enable cURL's verbose mode.

The existing http.c code already supports this and does it by simply checking to see whether or not the environment variable exists -- it does not examine the value at all.

For consistency, enable CURLOPT_VERBOSE when GIT_CURL_VERBOSE is set by using the exact same test that http.c does.

Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
---

*** PATCH IS AGAINST NEXT ***

In particular, this patch requires br/imap-send-via-libcurl

 imap-send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to imap-send.c +1 −1

diff --git a/imap-send.c b/imap-send.c
index 4dfe4c25..060df834 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
 
 	curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
 
-	if (0 < verbosity)
+	if (0 < verbosity || getenv("GIT_CURL_VERBOSE"))
 		curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
 
 	return curl;

-- 
2.1.4

Junio C Hamano· Jan 6, 2015, 20:17 UTC · re: Kyle J. McKay · lore

Re: [PATCH] imap-send.c: support GIT_CURL_VERBOSE

"Kyle J. McKay" <mackyle@gmail.com> writes:

Show 17 quoted lines

> When using git-imap-send to send via cURL, support setting
> the GIT_CURL_VERBOSE environment variable to enable cURL's
> verbose mode.
> ...
> diff --git a/imap-send.c b/imap-send.c
> index 4dfe4c25..060df834 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
>  
>  	curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
>  
> -	if (0 < verbosity)
> +	if (0 < verbosity || getenv("GIT_CURL_VERBOSE"))
>  		curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
>  
>  	return curl;

Makes sense; thanks.

patchimap-send.c: support GIT_CURL_VERBOSE