{"thread":{"id":"38292","subject":"[PATCH] imap-send.c: support GIT_CURL_VERBOSE","startedAt":"2015-01-06T11:00:55Z","lastAt":"2015-01-06T20:17:55Z","messageCount":2,"participants":["Kyle J. McKay","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254328","messageId":"ce80e4296739f2fce0d70ddf4a710fb@74d39fa044aa309eaea14b9f57fe79c","threadId":"38292","inReplyTo":null,"subject":"[PATCH] imap-send.c: support GIT_CURL_VERBOSE","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2015-01-06T11:00:55Z","receivedAt":"2015-01-06T11:00:55Z","isPatch":true,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"When using git-imap-send to send via cURL, support setting\nthe GIT_CURL_VERBOSE environment variable to enable cURL's\nverbose mode.\n\nThe existing http.c code already supports this and does\nit by simply checking to see whether or not the environment\nvariable exists -- it does not examine the value at all.\n\nFor consistency, enable CURLOPT_VERBOSE when GIT_CURL_VERBOSE\nis set by using the exact same test that http.c does.\n\nSigned-off-by: Kyle J. McKay <mackyle@gmail.com>\n---\n\n*** PATCH IS AGAINST NEXT ***\n\nIn particular, this patch requires br/imap-send-via-libcurl\n\n\n imap-send.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/imap-send.c b/imap-send.c\nindex 4dfe4c25..060df834 100644\n--- a/imap-send.c\n+++ b/imap-send.c\n@@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)\n \n \tcurl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);\n \n-\tif (0 < verbosity)\n+\tif (0 < verbosity || getenv(\"GIT_CURL_VERBOSE\"))\n \t\tcurl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);\n \n \treturn curl;\n-- \n2.1.4\n"},{"id":"254368","messageId":"xmqqmw5voe8c.fsf@gitster.dls.corp.google.com","threadId":"38292","inReplyTo":"ce80e4296739f2fce0d70ddf4a710fb@74d39fa044aa309eaea14b9f57fe79c","subject":"Re: [PATCH] imap-send.c: support GIT_CURL_VERBOSE","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-06T20:17:55Z","receivedAt":"2015-01-06T20:17:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kyle J. McKay\" <mackyle@gmail.com> writes:\n\n> When using git-imap-send to send via cURL, support setting\n> the GIT_CURL_VERBOSE environment variable to enable cURL's\n> verbose mode.\n> ...\n> diff --git a/imap-send.c b/imap-send.c\n> index 4dfe4c25..060df834 100644\n> --- a/imap-send.c\n> +++ b/imap-send.c\n> @@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)\n>  \n>  \tcurl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);\n>  \n> -\tif (0 < verbosity)\n> +\tif (0 < verbosity || getenv(\"GIT_CURL_VERBOSE\"))\n>  \t\tcurl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);\n>  \n>  \treturn curl;\n\nMakes sense; thanks.\n"}]}