# [PATCH] imap-send.c: support GIT_CURL_VERBOSE

2 messages from 2015-01-06 to 2015-01-06. Participants: Kyle J. McKay, Junio C Hamano.
Thread: https://gitlist.dev/t/38292

## Kyle J. McKay, 2015-01-06 11:00

Subject: [PATCH] imap-send.c: support GIT_CURL_VERBOSE
Message-ID: <ce80e4296739f2fce0d70ddf4a710fb@74d39fa044aa309eaea14b9f57fe79c>
URL: https://gitlist.dev/e/ce80e4296739f2fce0d70ddf4a710fb%4074d39fa044aa309eaea14b9f57fe79c

```
When using git-imap-send to send via cURL, support setting
the GIT_CURL_VERBOSE environment variable to enable cURL's
verbose mode.

The existing http.c code already supports this and does
it by simply checking to see whether or not the environment
variable exists -- it does not examine the value at all.

For consistency, enable CURLOPT_VERBOSE when GIT_CURL_VERBOSE
is set by using the exact same test that http.c does.

Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
---

*** PATCH IS AGAINST NEXT ***

In particular, this patch requires br/imap-send-via-libcurl


 imap-send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/imap-send.c b/imap-send.c
index 4dfe4c25..060df834 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
 
 	curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
 
-	if (0 < verbosity)
+	if (0 < verbosity || getenv("GIT_CURL_VERBOSE"))
 		curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
 
 	return curl;
-- 
2.1.4

```

## Junio C Hamano, 2015-01-06 20:17

Subject: Re: [PATCH] imap-send.c: support GIT_CURL_VERBOSE
Message-ID: <xmqqmw5voe8c.fsf@gitster.dls.corp.google.com>
URL: https://gitlist.dev/e/xmqqmw5voe8c.fsf%40gitster.dls.corp.google.com
In-Reply-To: <ce80e4296739f2fce0d70ddf4a710fb@74d39fa044aa309eaea14b9f57fe79c>

```
"Kyle J. McKay" <mackyle@gmail.com> writes:

> When using git-imap-send to send via cURL, support setting
> the GIT_CURL_VERBOSE environment variable to enable cURL's
> verbose mode.
> ...
> diff --git a/imap-send.c b/imap-send.c
> index 4dfe4c25..060df834 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1431,7 +1431,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
>  
>  	curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
>  
> -	if (0 < verbosity)
> +	if (0 < verbosity || getenv("GIT_CURL_VERBOSE"))
>  		curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
>  
>  	return curl;

Makes sense; thanks.

```