threads / patch / 38040

patchgit-sh-setup.sh: use dashdash with basename call

Subject: [PATCH] git-sh-setup.sh: use dashdash with basename call

## tl;dr

One message between Nov 24, 2014 and Nov 24, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Dan Wyand· Nov 24, 2014, 23:20 UTC · lore

Calling basename on a argument that starts with a dash, like a login shell, will result in an error. This patch adds '--' before the argument so that the argument is interpreted properly.

Signed-off-by: Dan Wyand <danwyand@gmail.com>
---
 git-sh-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to git-sh-setup.sh +1 −1
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 9447980..5cdae33 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -81,7 +81,7 @@ if test -n "$OPTIONS_SPEC"; then
 		echo exit $?
 	)"
 else
-	dashless=$(basename "$0" | sed -e 's/-/ /')
+	dashless=$(basename -- "$0" | sed -e 's/-/ /')
 	usage() {
 		die "usage: $dashless $USAGE"
 	}
-- 
2.1.3

← back to recent threads