{"thread":{"id":"38040","subject":"[PATCH] git-sh-setup.sh: use dashdash with basename call","startedAt":"2014-11-24T23:20:48Z","lastAt":"2014-11-24T23:20:48Z","messageCount":1,"participants":["Dan Wyand"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"252472","messageId":"1416871248-14185-1-git-send-email-danwyand@gmail.com","threadId":"38040","inReplyTo":null,"subject":"[PATCH] git-sh-setup.sh: use dashdash with basename call","fromName":"Dan Wyand","fromEmail":"danwyand@gmail.com","sentAt":"2014-11-24T23:20:48Z","receivedAt":"2014-11-24T23:20:48Z","isPatch":true,"sender":{"key":"danwyand@gmail.com","avatar":null},"body":"Calling basename on a argument that starts with a dash, like a login shell,\nwill result in an error. This patch adds '--' before the argument so that the\nargument is interpreted properly.\n\nSigned-off-by: Dan Wyand <danwyand@gmail.com>\n---\n git-sh-setup.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-sh-setup.sh b/git-sh-setup.sh\nindex 9447980..5cdae33 100644\n--- a/git-sh-setup.sh\n+++ b/git-sh-setup.sh\n@@ -81,7 +81,7 @@ if test -n \"$OPTIONS_SPEC\"; then\n \t\techo exit $?\n \t)\"\n else\n-\tdashless=$(basename \"$0\" | sed -e 's/-/ /')\n+\tdashless=$(basename -- \"$0\" | sed -e 's/-/ /')\n \tusage() {\n \t\tdie \"usage: $dashless $USAGE\"\n \t}\n-- \n2.1.3\n"}]}