git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-sh-setup.sh: use dashdash with basename call

From
DWDan Wyand <danwyand@gmail.com>
Date
Nov 24, 2014, 23:20 UTC
Message-ID
<1416871248-14185-1-git-send-email-danwyand@gmail.com>

Calling basename on a argument that starts with a dash, like a login shell, will result in an error. This patch adds '--' before the argument so that the argument is interpreted properly.

Signed-off-by: Dan Wyand <danwyand@gmail.com>
---
 git-sh-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 9447980..5cdae33 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -81,7 +81,7 @@ if test -n "$OPTIONS_SPEC"; then
 		echo exit $?
 	)"
 else
-	dashless=$(basename "$0" | sed -e 's/-/ /')
+	dashless=$(basename -- "$0" | sed -e 's/-/ /')
 	usage() {
 		die "usage: $dashless $USAGE"
 	}
-- 
2.1.3
Message 1 of 1 in “git-sh-setup.sh: use dashdash with basename call”
  1. git-sh-setup.sh: use dashdash with basename callDan Wyand, Nov 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.