threads / patch / 37793

patchreceive-pack.c: mark file local symbols as static

Subject: [PATCH] receive-pack.c: mark file local symbols as static

## tl;dr

One message between Oct 23, 2014 and Oct 23, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Oct 23, 2014, 22:58 UTC · lore

Commit 8796e182 ("receive-pack.c: use a single transaction when atomic-push is negotiated", 21-10-2014) added the 'transaction' and 'err' variables as external symbols.

Noticed by sparse. ("'err' was not declared. Should it be static?")
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Ronnie,

If you need to re-roll your 'rs/ref-transaction-send-pack' branch, could you please squash this into the re-rolled version of commit 8796e182.

Thanks!

ATB, Ramsay Jones

 builtin/receive-pack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to builtin/receive-pack.c +2 −2
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 030698c..7f6d814 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -68,8 +68,8 @@ static const char *NONCE_SLOP = "SLOP";
 static const char *nonce_status;
 static long nonce_stamp_slop;
 static unsigned long nonce_stamp_slop_limit;
-struct strbuf err = STRBUF_INIT;
-struct transaction *transaction;
+static struct strbuf err = STRBUF_INIT;
+static struct transaction *transaction;
 
 static enum deny_action parse_deny_action(const char *var, const char *value)
 {
-- 
2.1.0

← back to recent threads