git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] receive-pack.c: mark file local symbols as static

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Oct 23, 2014, 22:58 UTC
Message-ID
<5449880D.1020506@ramsay1.demon.co.uk>

Commit 8796e182 ("receive-pack.c: use a single transaction when atomic-push is negotiated", 21-10-2014) added the 'transaction' and 'err' variables as external symbols.

Noticed by sparse. ("'err' was not declared. Should it be static?")
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Ronnie,

If you need to re-roll your 'rs/ref-transaction-send-pack' branch, could you please squash this into the re-rolled version of commit 8796e182.

Thanks!

ATB, Ramsay Jones

 builtin/receive-pack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 030698c..7f6d814 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -68,8 +68,8 @@ static const char *NONCE_SLOP = "SLOP";
 static const char *nonce_status;
 static long nonce_stamp_slop;
 static unsigned long nonce_stamp_slop_limit;
-struct strbuf err = STRBUF_INIT;
-struct transaction *transaction;
+static struct strbuf err = STRBUF_INIT;
+static struct transaction *transaction;
 
 static enum deny_action parse_deny_action(const char *var, const char *value)
 {
-- 
2.1.0
Message 1 of 1 in “receive-pack.c: mark file local symbols as static”
  1. receive-pack.c: mark file local symbols as staticRamsay Jones, Oct 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.