{"thread":{"id":"37793","subject":"[PATCH] receive-pack.c: mark file local symbols as static","startedAt":"2014-10-23T22:58:21Z","lastAt":"2014-10-23T22:58:21Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251003","messageId":"5449880D.1020506@ramsay1.demon.co.uk","threadId":"37793","inReplyTo":null,"subject":"[PATCH] receive-pack.c: mark file local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-10-23T22:58:21Z","receivedAt":"2014-10-23T22:58:21Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 8796e182 (\"receive-pack.c: use a single transaction when\natomic-push is negotiated\", 21-10-2014) added the 'transaction'\nand 'err' variables as external symbols.\n\nNoticed by sparse. (\"'err' was not declared. Should it be static?\")\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Ronnie,\n\nIf you need to re-roll your 'rs/ref-transaction-send-pack' branch, could\nyou please squash this into the re-rolled version of commit 8796e182.\n\nThanks!\n\nATB,\nRamsay Jones\n\n\n builtin/receive-pack.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/receive-pack.c b/builtin/receive-pack.c\nindex 030698c..7f6d814 100644\n--- a/builtin/receive-pack.c\n+++ b/builtin/receive-pack.c\n@@ -68,8 +68,8 @@ static const char *NONCE_SLOP = \"SLOP\";\n static const char *nonce_status;\n static long nonce_stamp_slop;\n static unsigned long nonce_stamp_slop_limit;\n-struct strbuf err = STRBUF_INIT;\n-struct transaction *transaction;\n+static struct strbuf err = STRBUF_INIT;\n+static struct transaction *transaction;\n \n static enum deny_action parse_deny_action(const char *var, const char *value)\n {\n-- \n2.1.0\n"}]}