threads / patch / 37205

patchgit-svn: Avoid systematic prompt for client certificate when using "git svn branch"

Subject: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch"

## tl;dr

3 messages between Jul 24, 2014 and Aug 2, 2014. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Monard Vong· Jul 24, 2014, 16:25 UTC · lore

When a client certificate is required to connect to a Subversion repository, the certificate location and password may be stored in Subversion config directory. Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password if the location is set in SVN config file, but "git svn branch" does not use the config directory, resulting in prompting for certificate location/password all the time.

Build instance of SVN::Client in branch_cmd() with SVN config directory option instead of authentication baton. SVN::Client then builds its own authentication baton using information from the config directory.

Signed-off-by: Monard Vong <travelingsoul86@gmail.com>
---
 git-svn.perl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Show changes to git-svn.perl +3 −1

diff --git a/git-svn.perl b/git-svn.perl
index 0a32372..1f41ee1 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1161,7 +1161,9 @@ sub cmd_branch {
 	::_req_svn();
 
 	my $ctx = SVN::Client->new(
-		auth    => Git::SVN::Ra::_auth_providers(),
+		config => SVN::Core::config_get_config(
+			$Git::SVN::Ra::config_dir
+		),
 		log_msg => sub {
 			${ $_[0] } = defined $_message
 				? $_message

-- 
1.9.3

Eric Wong· Aug 2, 2014, 10:07 UTC · re: Monard Vong · lore

Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch"

Thanks. In the future, it's expected to Cc: anybody who showed interest in previous versions of your patch.

Monard Vong <travelingsoul86@gmail.com> wrote:

Show 5 quoted lines

> When a client certificate is required to connect to a Subversion repository,
> the certificate location and password may be stored in Subversion config directory.
> Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password
> if the location is set in SVN config file, but "git svn branch" does not use the config
> directory, resulting in prompting for certificate location/password all the time.

The commit message is probably too long, and needs to be line-wrapped.

Perhaps something like:
---------------------------8<---------------------------
Subject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass

Commands such as "git svn init/fetch/dcommit" do not prompt for client certificate/password if they are stored in SVN config file. Make "git svn branch" consistent with the other commands, as SVN::Client is capable of building its own authentication baton from information in the SVN config directory.

Signed-off-by: Monard Vong <travelingsoul86@gmail.com>
---------------------------8<---------------------------

I can push the above with my Signed-off-by if you are happy with it. Thanks again!

Monard Vong· Aug 2, 2014, 13:26 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch"

Le 02/08/2014 12:07, Eric Wong a écrit :

Show 26 quoted lines

> Thanks.  In the future, it's expected to Cc: anybody who showed interest
> in previous versions of your patch.
>
> Monard Vong <travelingsoul86@gmail.com> wrote:
>> When a client certificate is required to connect to a Subversion repository,
>> the certificate location and password may be stored in Subversion config directory.
>> Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password
>> if the location is set in SVN config file, but "git svn branch" does not use the config
>> directory, resulting in prompting for certificate location/password all the time.
> The commit message is probably too long, and needs to be line-wrapped.
>
> Perhaps something like:
> ---------------------------8<---------------------------
> Subject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass
>
> Commands such as "git svn init/fetch/dcommit" do not prompt for client
> certificate/password if they are stored in SVN config file.  Make "git
> svn branch" consistent with the other commands, as SVN::Client is
> capable of building its own authentication baton from information in the
> SVN config directory.
>
> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>
> ---------------------------8<---------------------------
>
> I can push the above with my Signed-off-by if you are happy with it.
> Thanks again!

Please do, all pleasure is mine, and thanks a lot for your feedback.

Monard