# [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch" 3 messages from 2014-07-24 to 2014-08-02. Participants: Monard Vong, Eric Wong. Thread: https://gitlist.dev/t/37205 ## Monard Vong, 2014-07-24 16:25 Subject: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch" Message-ID: <1406219159-4644-1-git-send-email-travelingsoul86@gmail.com> URL: https://gitlist.dev/e/1406219159-4644-1-git-send-email-travelingsoul86%40gmail.com In-Reply-To: <254135> ``` When a client certificate is required to connect to a Subversion repository, the certificate location and password may be stored in Subversion config directory. Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password if the location is set in SVN config file, but "git svn branch" does not use the config directory, resulting in prompting for certificate location/password all the time. Build instance of SVN::Client in branch_cmd() with SVN config directory option instead of authentication baton. SVN::Client then builds its own authentication baton using information from the config directory. Signed-off-by: Monard Vong --- git-svn.perl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/git-svn.perl b/git-svn.perl index 0a32372..1f41ee1 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1161,7 +1161,9 @@ sub cmd_branch { ::_req_svn(); my $ctx = SVN::Client->new( - auth => Git::SVN::Ra::_auth_providers(), + config => SVN::Core::config_get_config( + $Git::SVN::Ra::config_dir + ), log_msg => sub { ${ $_[0] } = defined $_message ? $_message -- 1.9.3 ``` ## Eric Wong, 2014-08-02 10:07 Subject: Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch" Message-ID: <20140802100719.GA13095@dcvr.yhbt.net> URL: https://gitlist.dev/e/20140802100719.GA13095%40dcvr.yhbt.net In-Reply-To: <1406219159-4644-1-git-send-email-travelingsoul86@gmail.com> ``` Thanks. In the future, it's expected to Cc: anybody who showed interest in previous versions of your patch. Monard Vong wrote: > When a client certificate is required to connect to a Subversion repository, > the certificate location and password may be stored in Subversion config directory. > Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password > if the location is set in SVN config file, but "git svn branch" does not use the config > directory, resulting in prompting for certificate location/password all the time. The commit message is probably too long, and needs to be line-wrapped. Perhaps something like: ---------------------------8<--------------------------- Subject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass Commands such as "git svn init/fetch/dcommit" do not prompt for client certificate/password if they are stored in SVN config file. Make "git svn branch" consistent with the other commands, as SVN::Client is capable of building its own authentication baton from information in the SVN config directory. Signed-off-by: Monard Vong ---------------------------8<--------------------------- I can push the above with my Signed-off-by if you are happy with it. Thanks again! ``` ## Monard Vong, 2014-08-02 13:26 Subject: Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using "git svn branch" Message-ID: <53DCE6F7.9040405@gmail.com> URL: https://gitlist.dev/e/53DCE6F7.9040405%40gmail.com In-Reply-To: <20140802100719.GA13095@dcvr.yhbt.net> ``` Le 02/08/2014 12:07, Eric Wong a écrit : > Thanks. In the future, it's expected to Cc: anybody who showed interest > in previous versions of your patch. > > Monard Vong wrote: >> When a client certificate is required to connect to a Subversion repository, >> the certificate location and password may be stored in Subversion config directory. >> Commands like "git svn init/fetch/dcommit" do not prompt for client certificate/password >> if the location is set in SVN config file, but "git svn branch" does not use the config >> directory, resulting in prompting for certificate location/password all the time. > The commit message is probably too long, and needs to be line-wrapped. > > Perhaps something like: > ---------------------------8<--------------------------- > Subject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass > > Commands such as "git svn init/fetch/dcommit" do not prompt for client > certificate/password if they are stored in SVN config file. Make "git > svn branch" consistent with the other commands, as SVN::Client is > capable of building its own authentication baton from information in the > SVN config directory. > > Signed-off-by: Monard Vong > ---------------------------8<--------------------------- > > I can push the above with my Signed-off-by if you are happy with it. > Thanks again! Please do, all pleasure is mine, and thanks a lot for your feedback. Monard ```