{"thread":{"id":"37205","subject":"[PATCH] git-svn: Avoid systematic prompt for client certificate when using \"git svn branch\"","startedAt":"2014-07-24T16:25:59Z","lastAt":"2014-08-02T13:26:15Z","messageCount":3,"participants":["Monard Vong","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"246648","messageId":"1406219159-4644-1-git-send-email-travelingsoul86@gmail.com","threadId":"37205","inReplyTo":"254135","subject":"[PATCH] git-svn: Avoid systematic prompt for client certificate when using \"git svn branch\"","fromName":"Monard Vong","fromEmail":"travelingsoul86@gmail.com","sentAt":"2014-07-24T16:25:59Z","receivedAt":"2014-07-24T16:25:59Z","isPatch":true,"sender":{"key":"travelingsoul86@gmail.com","avatar":null},"body":"When a client certificate is required to connect to a Subversion repository,\nthe certificate location and password may be stored in Subversion config directory.\nCommands like \"git svn init/fetch/dcommit\" do not prompt for client certificate/password\nif the location is set in SVN config file, but \"git svn branch\" does not use the config\ndirectory, resulting in prompting for certificate location/password all the time.\n\nBuild instance of SVN::Client in branch_cmd() with SVN config directory option instead\nof authentication baton. SVN::Client then builds its own authentication baton\nusing information from the config directory.\n\nSigned-off-by: Monard Vong <travelingsoul86@gmail.com>\n---\n git-svn.perl | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 0a32372..1f41ee1 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1161,7 +1161,9 @@ sub cmd_branch {\n \t::_req_svn();\n \n \tmy $ctx = SVN::Client->new(\n-\t\tauth    => Git::SVN::Ra::_auth_providers(),\n+\t\tconfig => SVN::Core::config_get_config(\n+\t\t\t$Git::SVN::Ra::config_dir\n+\t\t),\n \t\tlog_msg => sub {\n \t\t\t${ $_[0] } = defined $_message\n \t\t\t\t? $_message\n-- \n1.9.3\n"},{"id":"247166","messageId":"20140802100719.GA13095@dcvr.yhbt.net","threadId":"37205","inReplyTo":"1406219159-4644-1-git-send-email-travelingsoul86@gmail.com","subject":"Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using \"git svn branch\"","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2014-08-02T10:07:19Z","receivedAt":"2014-08-02T10:07:19Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Thanks.  In the future, it's expected to Cc: anybody who showed interest\nin previous versions of your patch.\n\nMonard Vong <travelingsoul86@gmail.com> wrote:\n> When a client certificate is required to connect to a Subversion repository,\n> the certificate location and password may be stored in Subversion config directory.\n> Commands like \"git svn init/fetch/dcommit\" do not prompt for client certificate/password\n> if the location is set in SVN config file, but \"git svn branch\" does not use the config\n> directory, resulting in prompting for certificate location/password all the time.\n\nThe commit message is probably too long, and needs to be line-wrapped.\n\nPerhaps something like:\n---------------------------8<---------------------------\nSubject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass\n\nCommands such as \"git svn init/fetch/dcommit\" do not prompt for client\ncertificate/password if they are stored in SVN config file.  Make \"git\nsvn branch\" consistent with the other commands, as SVN::Client is\ncapable of building its own authentication baton from information in the\nSVN config directory.\n\nSigned-off-by: Monard Vong <travelingsoul86@gmail.com>\n---------------------------8<---------------------------\n\nI can push the above with my Signed-off-by if you are happy with it.\nThanks again!\n"},{"id":"247169","messageId":"53DCE6F7.9040405@gmail.com","threadId":"37205","inReplyTo":"20140802100719.GA13095@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: Avoid systematic prompt for client certificate when using \"git svn branch\"","fromName":"Monard Vong","fromEmail":"travelingsoul86@gmail.com","sentAt":"2014-08-02T13:26:15Z","receivedAt":"2014-08-02T13:26:15Z","isPatch":true,"sender":{"key":"travelingsoul86@gmail.com","avatar":null},"body":"Le 02/08/2014 12:07, Eric Wong a écrit :\n> Thanks.  In the future, it's expected to Cc: anybody who showed interest\n> in previous versions of your patch.\n>\n> Monard Vong <travelingsoul86@gmail.com> wrote:\n>> When a client certificate is required to connect to a Subversion repository,\n>> the certificate location and password may be stored in Subversion config directory.\n>> Commands like \"git svn init/fetch/dcommit\" do not prompt for client certificate/password\n>> if the location is set in SVN config file, but \"git svn branch\" does not use the config\n>> directory, resulting in prompting for certificate location/password all the time.\n> The commit message is probably too long, and needs to be line-wrapped.\n>\n> Perhaps something like:\n> ---------------------------8<---------------------------\n> Subject: [PATCH] git-svn: branch: avoid systematic prompt for cert/pass\n>\n> Commands such as \"git svn init/fetch/dcommit\" do not prompt for client\n> certificate/password if they are stored in SVN config file.  Make \"git\n> svn branch\" consistent with the other commands, as SVN::Client is\n> capable of building its own authentication baton from information in the\n> SVN config directory.\n>\n> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>\n> ---------------------------8<---------------------------\n>\n> I can push the above with my Signed-off-by if you are happy with it.\n> Thanks again!\nPlease do, all pleasure is mine, and thanks a lot for your feedback.\n\nMonard\n"}]}