threads / patch / 37161

patchgit-svn: Initialize SVN::Client with svn config instead of, auth for "git svn branch".

Subject: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for "git svn branch".

## tl;dr

3 messages between Jul 18, 2014 and Jul 25, 2014. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Monard Vong· Jul 18, 2014, 14:58 UTC · lore

If a client certificate is required to connect to svn, "git svn branch" always prompt the user for the certificate location and password, even though those parameters are stored in svn file "server" located in svn config dir (generally ~/.subversion). On the opposite, "git svn info/init/dcommit" read the config dir and do not prompt if the parameters are set.

This commit initializes for "git svn branch", the SVN::Client with the 'config' option instead of 'auth'. As decribed in the SVN documentation, http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS the SVN::Client will then read cached authentication options.

Signed-off-by: Monard Vong <travelingsoul86@gmail.com>
---
  git-svn.perl | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Show changes to git-svn.perl +3 −1

diff --git a/git-svn.perl b/git-svn.perl
index 0a32372..1f41ee1 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1161,7 +1161,9 @@ sub cmd_branch {
      ::_req_svn();

      my $ctx = SVN::Client->new(
-        auth    => Git::SVN::Ra::_auth_providers(),
+        config => SVN::Core::config_get_config(
+            $Git::SVN::Ra::config_dir
+        ),
          log_msg => sub {
              ${ $_[0] } = defined $_message
                  ? $_message

-- 
1.9.3

Eric Wong· Jul 23, 2014, 22:33 UTC · re: Monard Vong · lore

Re: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for "git svn branch".

Monard Vong <travelingsoul86@gmail.com> wrote:

Show 14 quoted lines

> If a client certificate is required to connect to svn, "git svn branch"
> always prompt the user for the certificate location and password,
> even though those parameters are stored in svn file "server"
> located in svn config dir (generally ~/.subversion).
> On the opposite, "git svn info/init/dcommit" read the config dir
> and do not prompt if the parameters are set.
> 
> This commit initializes for "git svn branch", the SVN::Client with
> the 'config'
> option instead of 'auth'. As decribed in the SVN documentation,
> http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS
> the SVN::Client will then read cached authentication options.
> 
> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>

Thanks, I do not have a good way to test this, but the idea seems correct.

Your patch is whitespace mangled, and the commit message and subject needs to be improved (see Documentation/SubmittingPatches on how to describe your changes and how to send them without whitespace mangling.)

Thanks again.

Monard Vong· Jul 25, 2014, 09:49 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for "git svn branch".

Thanks for your reply, I updated commit message and subject, hoping it would be clearer. However I messed up "message-id" so it appear as a new message and not in the current thread. Sorry, still learning.

Le 24/07/2014 00:33, Eric Wong a écrit :

Show 23 quoted lines

> Monard Vong <travelingsoul86@gmail.com> wrote:
>> If a client certificate is required to connect to svn, "git svn branch"
>> always prompt the user for the certificate location and password,
>> even though those parameters are stored in svn file "server"
>> located in svn config dir (generally ~/.subversion).
>> On the opposite, "git svn info/init/dcommit" read the config dir
>> and do not prompt if the parameters are set.
>>
>> This commit initializes for "git svn branch", the SVN::Client with
>> the 'config'
>> option instead of 'auth'. As decribed in the SVN documentation,
>> http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS
>> the SVN::Client will then read cached authentication options.
>>
>> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>
> Thanks, I do not have a good way to test this, but the idea seems
> correct.
>
> Your patch is whitespace mangled, and the commit message and subject
> needs to be improved (see Documentation/SubmittingPatches on how to
> describe your changes and how to send them without whitespace mangling.)
>
> Thanks again.