Re: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for "git svn branch".

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 23, 2014, 22:33 UTC
Message-ID: <20140723223349.GB14145@dcvr.yhbt.net>
In-Reply-To: <53C93611.7090705@gmail.com>

Monard Vong <travelingsoul86@gmail.com> wrote:

Show 14 quoted lines

> If a client certificate is required to connect to svn, "git svn branch"
> always prompt the user for the certificate location and password,
> even though those parameters are stored in svn file "server"
> located in svn config dir (generally ~/.subversion).
> On the opposite, "git svn info/init/dcommit" read the config dir
> and do not prompt if the parameters are set.
> 
> This commit initializes for "git svn branch", the SVN::Client with
> the 'config'
> option instead of 'auth'. As decribed in the SVN documentation,
> http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS
> the SVN::Client will then read cached authentication options.
> 
> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>

Thanks, I do not have a good way to test this, but the idea seems correct.

Your patch is whitespace mangled, and the commit message and subject needs to be improved (see Documentation/SubmittingPatches on how to describe your changes and how to send them without whitespace mangling.)

Thanks again.