{"thread":{"id":"37161","subject":"[PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for \"git svn branch\".","startedAt":"2014-07-18T14:58:25Z","lastAt":"2014-07-25T09:49:45Z","messageCount":3,"participants":["Monard Vong","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"246311","messageId":"53C93611.7090705@gmail.com","threadId":"37161","inReplyTo":null,"subject":"[PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for \"git svn branch\".","fromName":"Monard Vong","fromEmail":"travelingsoul86@gmail.com","sentAt":"2014-07-18T14:58:25Z","receivedAt":"2014-07-18T14:58:25Z","isPatch":true,"sender":{"key":"travelingsoul86@gmail.com","avatar":null},"body":"If a client certificate is required to connect to svn, \"git svn branch\"\nalways prompt the user for the certificate location and password,\neven though those parameters are stored in svn file \"server\"\nlocated in svn config dir (generally ~/.subversion).\nOn the opposite, \"git svn info/init/dcommit\" read the config dir\nand do not prompt if the parameters are set.\n\nThis commit initializes for \"git svn branch\", the SVN::Client with the \n'config'\noption instead of 'auth'. As decribed in the SVN documentation,\nhttp://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS\nthe SVN::Client will then read cached authentication options.\n\nSigned-off-by: Monard Vong <travelingsoul86@gmail.com>\n---\n  git-svn.perl | 4 +++-\n  1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 0a32372..1f41ee1 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1161,7 +1161,9 @@ sub cmd_branch {\n      ::_req_svn();\n\n      my $ctx = SVN::Client->new(\n-        auth    => Git::SVN::Ra::_auth_providers(),\n+        config => SVN::Core::config_get_config(\n+            $Git::SVN::Ra::config_dir\n+        ),\n          log_msg => sub {\n              ${ $_[0] } = defined $_message\n                  ? $_message\n-- \n1.9.3\n"},{"id":"246618","messageId":"20140723223349.GB14145@dcvr.yhbt.net","threadId":"37161","inReplyTo":"53C93611.7090705@gmail.com","subject":"Re: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for \"git svn branch\".","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2014-07-23T22:33:49Z","receivedAt":"2014-07-23T22:33:49Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Monard Vong <travelingsoul86@gmail.com> wrote:\n> If a client certificate is required to connect to svn, \"git svn branch\"\n> always prompt the user for the certificate location and password,\n> even though those parameters are stored in svn file \"server\"\n> located in svn config dir (generally ~/.subversion).\n> On the opposite, \"git svn info/init/dcommit\" read the config dir\n> and do not prompt if the parameters are set.\n> \n> This commit initializes for \"git svn branch\", the SVN::Client with\n> the 'config'\n> option instead of 'auth'. As decribed in the SVN documentation,\n> http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS\n> the SVN::Client will then read cached authentication options.\n> \n> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>\n\nThanks, I do not have a good way to test this, but the idea seems\ncorrect.\n\nYour patch is whitespace mangled, and the commit message and subject\nneeds to be improved (see Documentation/SubmittingPatches on how to\ndescribe your changes and how to send them without whitespace mangling.)\n\nThanks again.\n"},{"id":"246683","messageId":"53D22839.6080400@gmail.com","threadId":"37161","inReplyTo":"20140723223349.GB14145@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: Initialize SVN::Client with svn config instead of, auth for \"git svn branch\".","fromName":"Monard Vong","fromEmail":"travelingsoul86@gmail.com","sentAt":"2014-07-25T09:49:45Z","receivedAt":"2014-07-25T09:49:45Z","isPatch":true,"sender":{"key":"travelingsoul86@gmail.com","avatar":null},"body":"Thanks for your reply, I updated commit message and subject, hoping it \nwould be clearer.\nHowever I messed up \"message-id\" so it appear as a new message and not \nin the current thread.\nSorry, still learning.\n\n\nLe 24/07/2014 00:33, Eric Wong a écrit :\n> Monard Vong <travelingsoul86@gmail.com> wrote:\n>> If a client certificate is required to connect to svn, \"git svn branch\"\n>> always prompt the user for the certificate location and password,\n>> even though those parameters are stored in svn file \"server\"\n>> located in svn config dir (generally ~/.subversion).\n>> On the opposite, \"git svn info/init/dcommit\" read the config dir\n>> and do not prompt if the parameters are set.\n>>\n>> This commit initializes for \"git svn branch\", the SVN::Client with\n>> the 'config'\n>> option instead of 'auth'. As decribed in the SVN documentation,\n>> http://search.cpan.org/~mschwern/Alien-SVN-v1.7.17.1/src/subversion/subversion/bindings/swig/perl/native/Client.pm#METHODS\n>> the SVN::Client will then read cached authentication options.\n>>\n>> Signed-off-by: Monard Vong <travelingsoul86@gmail.com>\n> Thanks, I do not have a good way to test this, but the idea seems\n> correct.\n>\n> Your patch is whitespace mangled, and the commit message and subject\n> needs to be improved (see Documentation/SubmittingPatches on how to\n> describe your changes and how to send them without whitespace mangling.)\n>\n> Thanks again.\n"}]}