threads / patch / 37059

patchrefs: Fix valgrind suppression file

Subject: [PATCH] refs: Fix valgrind suppression file

## tl;dr

2 messages between Jul 4, 2014 and Jul 7, 2014. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

David Turner· Jul 4, 2014, 20:24 UTC · lore

Add all of the ways in which check_refname_format violates valgrind's expectations to the valgrind suppression file; remove an assumption about the call chain of check_refname_format from same.

Signed-off-by: David Turner <dturner@twitter.com>
---
 t/valgrind/default.supp | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

Show changes to t/valgrind/default.supp +11 −4

diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp
index 332ab1a..9d51c92 100644
--- a/t/valgrind/default.supp
+++ b/t/valgrind/default.supp
@@ -50,10 +50,17 @@
 	fun:copy_ref
 }
 {
-	ignore-sse-check_refname_format
+	ignore-sse-check_refname_format-addr
 	Memcheck:Addr8
 	fun:check_refname_format
-	fun:cmd_check_ref_format
-	fun:handle_builtin
-	fun:main
+}
+{
+	ignore-sse-check_refname_format-cond
+	Memcheck:Cond
+	fun:check_refname_format
+}
+{
+	ignore-sse-check_refname_format-value
+	Memcheck:Value8
+	fun:check_refname_format
 }

-- 
2.0.0.390.gcb682f8

Junio C Hamano· Jul 7, 2014, 18:20 UTC · re: David Turner · lore

Re: [PATCH] refs: Fix valgrind suppression file

David Turner <dturner@twopensource.com> writes:

Show 8 quoted lines

> Add all of the ways in which check_refname_format violates valgrind's
> expectations to the valgrind suppression file; remove an assumption about
> the call chain of check_refname_format from same.
>
> Signed-off-by: David Turner <dturner@twitter.com>
> ---
>  t/valgrind/default.supp | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

I'll queue, but it makes me feel more and more disgusted with that SSE patch, to be honest.

Show 27 quoted lines

>
> diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp
> index 332ab1a..9d51c92 100644
> --- a/t/valgrind/default.supp
> +++ b/t/valgrind/default.supp
> @@ -50,10 +50,17 @@
>  	fun:copy_ref
>  }
>  {
> -	ignore-sse-check_refname_format
> +	ignore-sse-check_refname_format-addr
>  	Memcheck:Addr8
>  	fun:check_refname_format
> -	fun:cmd_check_ref_format
> -	fun:handle_builtin
> -	fun:main
> +}
> +{
> +	ignore-sse-check_refname_format-cond
> +	Memcheck:Cond
> +	fun:check_refname_format
> +}
> +{
> +	ignore-sse-check_refname_format-value
> +	Memcheck:Value8
> +	fun:check_refname_format
>  }