{"thread":{"id":"37059","subject":"[PATCH] refs: Fix valgrind suppression file","startedAt":"2014-07-04T20:24:01Z","lastAt":"2014-07-07T18:20:41Z","messageCount":2,"participants":["David Turner","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"245411","messageId":"1404505441-1853-1-git-send-email-dturner@twitter.com","threadId":"37059","inReplyTo":null,"subject":"[PATCH] refs: Fix valgrind suppression file","fromName":"David Turner","fromEmail":"dturner@twopensource.com","sentAt":"2014-07-04T20:24:01Z","receivedAt":"2014-07-04T20:24:01Z","isPatch":true,"sender":{"key":"novalis@novalis.org","avatar":"https://avatars.githubusercontent.com/u/77003?v=4"},"body":"Add all of the ways in which check_refname_format violates valgrind's\nexpectations to the valgrind suppression file; remove an assumption about\nthe call chain of check_refname_format from same.\n\nSigned-off-by: David Turner <dturner@twitter.com>\n---\n t/valgrind/default.supp | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)\n\ndiff --git a/t/valgrind/default.supp b/t/valgrind/default.supp\nindex 332ab1a..9d51c92 100644\n--- a/t/valgrind/default.supp\n+++ b/t/valgrind/default.supp\n@@ -50,10 +50,17 @@\n \tfun:copy_ref\n }\n {\n-\tignore-sse-check_refname_format\n+\tignore-sse-check_refname_format-addr\n \tMemcheck:Addr8\n \tfun:check_refname_format\n-\tfun:cmd_check_ref_format\n-\tfun:handle_builtin\n-\tfun:main\n+}\n+{\n+\tignore-sse-check_refname_format-cond\n+\tMemcheck:Cond\n+\tfun:check_refname_format\n+}\n+{\n+\tignore-sse-check_refname_format-value\n+\tMemcheck:Value8\n+\tfun:check_refname_format\n }\n-- \n2.0.0.390.gcb682f8\n"},{"id":"245485","messageId":"xmqqy4w5c9om.fsf@gitster.dls.corp.google.com","threadId":"37059","inReplyTo":"1404505441-1853-1-git-send-email-dturner@twitter.com","subject":"Re: [PATCH] refs: Fix valgrind suppression file","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-07-07T18:20:41Z","receivedAt":"2014-07-07T18:20:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Turner <dturner@twopensource.com> writes:\n\n> Add all of the ways in which check_refname_format violates valgrind's\n> expectations to the valgrind suppression file; remove an assumption about\n> the call chain of check_refname_format from same.\n>\n> Signed-off-by: David Turner <dturner@twitter.com>\n> ---\n>  t/valgrind/default.supp | 15 +++++++++++----\n>  1 file changed, 11 insertions(+), 4 deletions(-)\n\nI'll queue, but it makes me feel more and more disgusted with that\nSSE patch, to be honest.\n\n>\n> diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp\n> index 332ab1a..9d51c92 100644\n> --- a/t/valgrind/default.supp\n> +++ b/t/valgrind/default.supp\n> @@ -50,10 +50,17 @@\n>  \tfun:copy_ref\n>  }\n>  {\n> -\tignore-sse-check_refname_format\n> +\tignore-sse-check_refname_format-addr\n>  \tMemcheck:Addr8\n>  \tfun:check_refname_format\n> -\tfun:cmd_check_ref_format\n> -\tfun:handle_builtin\n> -\tfun:main\n> +}\n> +{\n> +\tignore-sse-check_refname_format-cond\n> +\tMemcheck:Cond\n> +\tfun:check_refname_format\n> +}\n> +{\n> +\tignore-sse-check_refname_format-value\n> +\tMemcheck:Value8\n> +\tfun:check_refname_format\n>  }\n"}]}