# [PATCH] refs: Fix valgrind suppression file 2 messages from 2014-07-04 to 2014-07-07. Participants: David Turner, Junio C Hamano. Thread: https://gitlist.dev/t/37059 ## David Turner, 2014-07-04 20:24 Subject: [PATCH] refs: Fix valgrind suppression file Message-ID: <1404505441-1853-1-git-send-email-dturner@twitter.com> URL: https://gitlist.dev/e/1404505441-1853-1-git-send-email-dturner%40twitter.com ``` Add all of the ways in which check_refname_format violates valgrind's expectations to the valgrind suppression file; remove an assumption about the call chain of check_refname_format from same. Signed-off-by: David Turner --- t/valgrind/default.supp | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp index 332ab1a..9d51c92 100644 --- a/t/valgrind/default.supp +++ b/t/valgrind/default.supp @@ -50,10 +50,17 @@ fun:copy_ref } { - ignore-sse-check_refname_format + ignore-sse-check_refname_format-addr Memcheck:Addr8 fun:check_refname_format - fun:cmd_check_ref_format - fun:handle_builtin - fun:main +} +{ + ignore-sse-check_refname_format-cond + Memcheck:Cond + fun:check_refname_format +} +{ + ignore-sse-check_refname_format-value + Memcheck:Value8 + fun:check_refname_format } -- 2.0.0.390.gcb682f8 ``` ## Junio C Hamano, 2014-07-07 18:20 Subject: Re: [PATCH] refs: Fix valgrind suppression file Message-ID: URL: https://gitlist.dev/e/xmqqy4w5c9om.fsf%40gitster.dls.corp.google.com In-Reply-To: <1404505441-1853-1-git-send-email-dturner@twitter.com> ``` David Turner writes: > Add all of the ways in which check_refname_format violates valgrind's > expectations to the valgrind suppression file; remove an assumption about > the call chain of check_refname_format from same. > > Signed-off-by: David Turner > --- > t/valgrind/default.supp | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) I'll queue, but it makes me feel more and more disgusted with that SSE patch, to be honest. > > diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp > index 332ab1a..9d51c92 100644 > --- a/t/valgrind/default.supp > +++ b/t/valgrind/default.supp > @@ -50,10 +50,17 @@ > fun:copy_ref > } > { > - ignore-sse-check_refname_format > + ignore-sse-check_refname_format-addr > Memcheck:Addr8 > fun:check_refname_format > - fun:cmd_check_ref_format > - fun:handle_builtin > - fun:main > +} > +{ > + ignore-sse-check_refname_format-cond > + Memcheck:Cond > + fun:check_refname_format > +} > +{ > + ignore-sse-check_refname_format-value > + Memcheck:Value8 > + fun:check_refname_format > } ```