Is column.ui.* configuration a bit too strong?

Junio C Hamano· Jun 23, 2014, 19:03 UTC · lore

Since its inception at 7e29b825 (Add column layout skeleton and git-column, 2012-04-21), it seems that git_column_config() asked for a specific $command did not give "column.$command.*" any precedence over the fallback value defined for "column.ui.*". If you happen to have column.ui.* earlier than the corresponding column.$command.* in your configuration, then the values come from column.ui.* may be overwritten, but the code does not seem to enforce "if there is a setting for a specific command, honor that, otherwise fall back to the generic 'ui' setting".

Am I misreading the code?

Duy Nguyen· Jun 24, 2014, 12:00 UTC · re: Junio C Hamano · lore

Re: Is column.ui.* configuration a bit too strong?

On Tue, Jun 24, 2014 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Since its inception at 7e29b825 (Add column layout skeleton and
> git-column, 2012-04-21), it seems that git_column_config() asked for
> a specific $command did not give "column.$command.*" any precedence
> over the fallback value defined for "column.ui.*".  If you happen to
> have column.ui.* earlier than the corresponding column.$command.* in
> your configuration, then the values come from column.ui.* may be
> overwritten, but the code does not seem to enforce "if there is a
> setting for a specific command, honor that, otherwise fall back to
> the generic 'ui' setting".
>
> Am I misreading the code?

Hmm.. probably not. The way I read it, the git_column_config() relies on the order that git_config() calls it, which should be "undefined order" from git_column_config point of view.

-- 
Duy