# Is column.ui.* configuration a bit too strong? 2 messages from 2014-06-23 to 2014-06-24. Participants: Junio C Hamano, Duy Nguyen. Thread: https://gitlist.dev/t/36983 ## Junio C Hamano, 2014-06-23 19:03 Subject: Is column.ui.* configuration a bit too strong? Message-ID: URL: https://gitlist.dev/e/xmqqsimvbg9c.fsf%40gitster.dls.corp.google.com ``` Since its inception at 7e29b825 (Add column layout skeleton and git-column, 2012-04-21), it seems that git_column_config() asked for a specific $command did not give "column.$command.*" any precedence over the fallback value defined for "column.ui.*". If you happen to have column.ui.* earlier than the corresponding column.$command.* in your configuration, then the values come from column.ui.* may be overwritten, but the code does not seem to enforce "if there is a setting for a specific command, honor that, otherwise fall back to the generic 'ui' setting". Am I misreading the code? ``` ## Duy Nguyen, 2014-06-24 12:00 Subject: Re: Is column.ui.* configuration a bit too strong? Message-ID: URL: https://gitlist.dev/e/CACsJy8DfKCEQ961mF09e8%3DCed6v-CGes%3DVN65ViAMBrNRk04Eg%40mail.gmail.com In-Reply-To: ``` On Tue, Jun 24, 2014 at 2:03 AM, Junio C Hamano wrote: > Since its inception at 7e29b825 (Add column layout skeleton and > git-column, 2012-04-21), it seems that git_column_config() asked for > a specific $command did not give "column.$command.*" any precedence > over the fallback value defined for "column.ui.*". If you happen to > have column.ui.* earlier than the corresponding column.$command.* in > your configuration, then the values come from column.ui.* may be > overwritten, but the code does not seem to enforce "if there is a > setting for a specific command, honor that, otherwise fall back to > the generic 'ui' setting". > > Am I misreading the code? Hmm.. probably not. The way I read it, the git_column_config() relies on the order that git_config() calls it, which should be "undefined order" from git_column_config point of view. -- Duy ```