{"thread":{"id":"36983","subject":"Is column.ui.* configuration a bit too strong?","startedAt":"2014-06-23T19:03:11Z","lastAt":"2014-06-24T12:00:44Z","messageCount":2,"participants":["Junio C Hamano","Duy Nguyen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"244890","messageId":"xmqqsimvbg9c.fsf@gitster.dls.corp.google.com","threadId":"36983","inReplyTo":null,"subject":"Is column.ui.* configuration a bit too strong?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-06-23T19:03:11Z","receivedAt":"2014-06-23T19:03:11Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Since its inception at 7e29b825 (Add column layout skeleton and\ngit-column, 2012-04-21), it seems that git_column_config() asked for\na specific $command did not give \"column.$command.*\" any precedence\nover the fallback value defined for \"column.ui.*\".  If you happen to\nhave column.ui.* earlier than the corresponding column.$command.* in\nyour configuration, then the values come from column.ui.* may be\noverwritten, but the code does not seem to enforce \"if there is a\nsetting for a specific command, honor that, otherwise fall back to\nthe generic 'ui' setting\".\n\nAm I misreading the code?\n"},{"id":"244926","messageId":"CACsJy8DfKCEQ961mF09e8=Ced6v-CGes=VN65ViAMBrNRk04Eg@mail.gmail.com","threadId":"36983","inReplyTo":"xmqqsimvbg9c.fsf@gitster.dls.corp.google.com","subject":"Re: Is column.ui.* configuration a bit too strong?","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2014-06-24T12:00:44Z","receivedAt":"2014-06-24T12:00:44Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Tue, Jun 24, 2014 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Since its inception at 7e29b825 (Add column layout skeleton and\n> git-column, 2012-04-21), it seems that git_column_config() asked for\n> a specific $command did not give \"column.$command.*\" any precedence\n> over the fallback value defined for \"column.ui.*\".  If you happen to\n> have column.ui.* earlier than the corresponding column.$command.* in\n> your configuration, then the values come from column.ui.* may be\n> overwritten, but the code does not seem to enforce \"if there is a\n> setting for a specific command, honor that, otherwise fall back to\n> the generic 'ui' setting\".\n>\n> Am I misreading the code?\n\nHmm.. probably not. The way I read it, the git_column_config() relies\non the order that git_config() calls it, which should be \"undefined\norder\" from git_column_config point of view.\n-- \nDuy\n"}]}