threads / patch / 35557

patchdaemon: be strict at parsing parameters --[no-]informative-errors

Subject: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors

## tl;dr

2 messages between Dec 20, 2013 and Dec 20, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Nguyễn Thái Ngọc Duy· Dec 20, 2013, 10:53 UTC · lore

Use strcmp() instead of starts_with() to stop accepting --informative-errors-just-a-little

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 daemon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to daemon.c +2 −2

diff --git a/daemon.c b/daemon.c
index 7bee953..503e039 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1278,11 +1278,11 @@ int main(int argc, char **argv)
 			make_service_overridable(arg + 18, 0);
 			continue;
 		}
-		if (starts_with(arg, "--informative-errors")) {
+		if (!strcmp(arg, "--informative-errors")) {
 			informative_errors = 1;
 			continue;
 		}
-		if (starts_with(arg, "--no-informative-errors")) {
+		if (!strcmp(arg, "--no-informative-errors")) {
 			informative_errors = 0;
 			continue;
 		}

-- 
1.8.5.1.208.g019362e

Jonathan Nieder· Dec 20, 2013, 18:46 UTC · re: Nguyễn Thái Ngọc Duy · lore

Re: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors

Hi,

Nguyễn Thái Ngọc Duy wrote:

> Use strcmp() instead of starts_with() to stop accepting
> --informative-errors-just-a-little
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Good catch. When this use of prefixcmp was introduced in v1.7.8-rc0~28^2 (daemon: give friendlier error messages to clients, 2011-10-14) I think it was just a typo.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>