# [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors 2 messages from 2013-12-20 to 2013-12-20. Participants: Nguyễn Thái Ngọc Duy, Jonathan Nieder. Thread: https://gitlist.dev/t/35557 ## Nguyễn Thái Ngọc Duy, 2013-12-20 10:53 Subject: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors Message-ID: <1387536832-650-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1387536832-650-1-git-send-email-pclouds%40gmail.com ``` Use strcmp() instead of starts_with() to stop accepting --informative-errors-just-a-little Signed-off-by: Nguyễn Thái Ngọc Duy --- daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon.c b/daemon.c index 7bee953..503e039 100644 --- a/daemon.c +++ b/daemon.c @@ -1278,11 +1278,11 @@ int main(int argc, char **argv) make_service_overridable(arg + 18, 0); continue; } - if (starts_with(arg, "--informative-errors")) { + if (!strcmp(arg, "--informative-errors")) { informative_errors = 1; continue; } - if (starts_with(arg, "--no-informative-errors")) { + if (!strcmp(arg, "--no-informative-errors")) { informative_errors = 0; continue; } -- 1.8.5.1.208.g019362e ``` ## Jonathan Nieder, 2013-12-20 18:46 Subject: Re: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors Message-ID: <20131220184644.GA10609@google.com> URL: https://gitlist.dev/e/20131220184644.GA10609%40google.com In-Reply-To: <1387536832-650-1-git-send-email-pclouds@gmail.com> ``` Hi, Nguyễn Thái Ngọc Duy wrote: > Use strcmp() instead of starts_with() to stop accepting > --informative-errors-just-a-little > > Signed-off-by: Nguyễn Thái Ngọc Duy Good catch. When this use of prefixcmp was introduced in v1.7.8-rc0~28^2 (daemon: give friendlier error messages to clients, 2011-10-14) I think it was just a typo. Reviewed-by: Jonathan Nieder ```