Re: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Dec 20, 2013, 18:46 UTC
- Message-ID
- <20131220184644.GA10609@google.com>
- In-Reply-To
- <1387536832-650-1-git-send-email-pclouds@gmail.com>
Hi,
Nguyễn Thái Ngọc Duy wrote:
> Use strcmp() instead of starts_with() to stop accepting > --informative-errors-just-a-little > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Good catch. When this use of prefixcmp was introduced in v1.7.8-rc0~28^2 (daemon: give friendlier error messages to clients, 2011-10-14) I think it was just a typo.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>