threads / patch / 34973

patcht5541: mark passing c-a-s test as success

Subject: [PATCH] t5541: mark passing c-a-s test as success

## tl;dr

2 messages between Sep 20, 2013 and Sep 20, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jeff King· Sep 20, 2013, 10:25 UTC · lore

Commit 05c1eb1 (push: teach --force-with-lease to smart-http transport) fixed the compare-and-swap test in t5541. It tried to mark the test as passing by teaching the test helper function to expect an extra "success or failure" parameter, but forgot to actually use the parameter in the helper.

Signed-off-by: Jeff King <peff@peff.net>
---
On top of jc/push-cas.
 t/lib-httpd.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/lib-httpd.sh +1 −1
diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
index dab405d..54dbbfe 100644
--- a/t/lib-httpd.sh
+++ b/t/lib-httpd.sh
@@ -169,7 +169,7 @@ test_http_push_nonff () {
 		test_i18ngrep "Updates were rejected because" output
 	'
 
-	test_expect_failure 'force with lease aka cas' '
+	test_expect_${EXPECT_CAS_RESULT} 'force with lease aka cas' '
 		HEAD=$(	cd "$REMOTE_REPO" && git rev-parse --verify HEAD ) &&
 		test_when_finished '\''
 			(cd "$REMOTE_REPO" && git update-ref HEAD "$HEAD")
-- 
1.8.4.37.g67196dd

← back to recent threads