{"thread":{"id":"34973","subject":"[PATCH] t5541: mark passing c-a-s test as success","startedAt":"2013-09-20T10:25:00Z","lastAt":"2013-09-20T18:18:11Z","messageCount":2,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"227932","messageId":"20130920102459.GA26914@sigill.intra.peff.net","threadId":"34973","inReplyTo":null,"subject":"[PATCH] t5541: mark passing c-a-s test as success","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-09-20T10:25:00Z","receivedAt":"2013-09-20T10:25:00Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit 05c1eb1 (push: teach --force-with-lease to smart-http\ntransport) fixed the compare-and-swap test in t5541. It\ntried to mark the test as passing by teaching the test\nhelper function to expect an extra \"success or failure\"\nparameter, but forgot to actually use the parameter in the\nhelper.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nOn top of jc/push-cas.\n\n t/lib-httpd.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/lib-httpd.sh b/t/lib-httpd.sh\nindex dab405d..54dbbfe 100644\n--- a/t/lib-httpd.sh\n+++ b/t/lib-httpd.sh\n@@ -169,7 +169,7 @@ test_http_push_nonff () {\n \t\ttest_i18ngrep \"Updates were rejected because\" output\n \t'\n \n-\ttest_expect_failure 'force with lease aka cas' '\n+\ttest_expect_${EXPECT_CAS_RESULT} 'force with lease aka cas' '\n \t\tHEAD=$(\tcd \"$REMOTE_REPO\" && git rev-parse --verify HEAD ) &&\n \t\ttest_when_finished '\\''\n \t\t\t(cd \"$REMOTE_REPO\" && git update-ref HEAD \"$HEAD\")\n-- \n1.8.4.37.g67196dd\n"},{"id":"227943","messageId":"xmqq1u4jqrvg.fsf@gitster.dls.corp.google.com","threadId":"34973","inReplyTo":"20130920102459.GA26914@sigill.intra.peff.net","subject":"Re: [PATCH] t5541: mark passing c-a-s test as success","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-09-20T18:18:11Z","receivedAt":"2013-09-20T18:18:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}