git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5541: mark passing c-a-s test as success

From
Jeff King <peff@peff.net>
Date
Sep 20, 2013, 10:25 UTC
Message-ID
<20130920102459.GA26914@sigill.intra.peff.net>

Commit 05c1eb1 (push: teach --force-with-lease to smart-http transport) fixed the compare-and-swap test in t5541. It tried to mark the test as passing by teaching the test helper function to expect an extra "success or failure" parameter, but forgot to actually use the parameter in the helper.

Signed-off-by: Jeff King <peff@peff.net>
---
On top of jc/push-cas.
 t/lib-httpd.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
index dab405d..54dbbfe 100644
--- a/t/lib-httpd.sh
+++ b/t/lib-httpd.sh
@@ -169,7 +169,7 @@ test_http_push_nonff () {
 		test_i18ngrep "Updates were rejected because" output
 	'
 
-	test_expect_failure 'force with lease aka cas' '
+	test_expect_${EXPECT_CAS_RESULT} 'force with lease aka cas' '
 		HEAD=$(	cd "$REMOTE_REPO" && git rev-parse --verify HEAD ) &&
 		test_when_finished '\''
 			(cd "$REMOTE_REPO" && git update-ref HEAD "$HEAD")
-- 
1.8.4.37.g67196dd
Next: Junio C Hamano
Message 1 of 2 in “t5541: mark passing c-a-s test as success”
  1. t5541: mark passing c-a-s test as successJeff King, Sep 20, 2013
  2. Junio C HamanoSep 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.