threads / discuss / 34807

[GIT PULL] hotfix on fr.po for the maint branch

Subject: [GIT PULL] hotfix on fr.po for the maint branch

## tl;dr

4 messages between Aug 30, 2013 and Aug 30, 2013.

replies: 3people: 3as markdown or json

Jiang Xin· Aug 30, 2013, 09:07 UTC · lore

Hi, Junio

Please merge this commit to the maint branch.

The following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:

  Git 1.8.4 (2013-08-23 11:49:46 -0700)

are available in the git repository at:

  git://github.com/git-l10n/git-po master

for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:

  l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)

----------------------------------------------------------------
Sebastien Helleu (1):
      l10n: fr.po: hotfix for commit 6b388fc

 po/TEAMS |    1 +
 po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------
 2 files changed, 874 insertions(+), 718 deletions(-)

-- Jiang Xin

Junio C Hamano· Aug 30, 2013, 16:54 UTC · re: Jiang Xin · lore

Re: [GIT PULL] hotfix on fr.po for the maint branch

Jiang Xin <worldhello.net@gmail.com> writes:

Show 17 quoted lines

> Please merge this commit to the maint branch.
>
> The following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:
>
>   Git 1.8.4 (2013-08-23 11:49:46 -0700)
>
> are available in the git repository at:
>
>   git://github.com/git-l10n/git-po master
>
> for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
>
>   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
>
> ----------------------------------------------------------------
> Sebastien Helleu (1):
>       l10n: fr.po: hotfix for commit 6b388fc

Hmph, what happened that requires a "hotfix" to message strings?

Show 7 quoted lines

>
>  po/TEAMS |    1 +
>  po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------
>  2 files changed, 874 insertions(+), 718 deletions(-)
>
> --
> Jiang Xin

Jean-Noël AVILA· Aug 30, 2013, 17:23 UTC · re: Junio C Hamano · lore

Re: [GIT PULL] hotfix on fr.po for the maint branch

Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :

> Jiang Xin <worldhello.net@gmail.com> writes:
> > Please merge this commit to the maint branch.
> > 
> > The following changes since commit

e230c568c4b9a991e3175e5f65171a566fd8e39c:

Show 14 quoted lines

> >   Git 1.8.4 (2013-08-23 11:49:46 -0700)
> > 
> > are available in the git repository at:
> >   git://github.com/git-l10n/git-po master
> > 
> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
> >   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
> > 
> > ----------------------------------------------------------------
> > 
> > Sebastien Helleu (1):
> >       l10n: fr.po: hotfix for commit 6b388fc
> 
> Hmph, what happened that requires a "hotfix" to message strings?

Well, as the author of the first commit,, I must say that the quality was not good. But it became visible and hooked up a reviewer only when it was promoted to stable version...

There are some strings that do not make sense in the usage pages, a missing %s in one. Agreed that applying this patch does not solve a critical issue, but it is low risk.

Show 8 quoted lines

> 
> >  po/TEAMS |    1 +
> >  po/fr.po | 1591
> >  ++++++++++++++++++++++++++++++++++---------------------------- 2 files
> >  changed, 874 insertions(+), 718 deletions(-)
> > 
> > --
> > Jiang Xin

Junio C Hamano· Aug 30, 2013, 18:07 UTC · re: Jean-Noël AVILA · lore

Re: [GIT PULL] hotfix on fr.po for the maint branch

Jean-Noël AVILA <jn.avila@free.fr> writes:

Show 28 quoted lines

> Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :
>> Jiang Xin <worldhello.net@gmail.com> writes:
>> > Please merge this commit to the maint branch.
>> > 
>> > The following changes since commit 
> e230c568c4b9a991e3175e5f65171a566fd8e39c:
>> >   Git 1.8.4 (2013-08-23 11:49:46 -0700)
>> > 
>> > are available in the git repository at:
>> >   git://github.com/git-l10n/git-po master
>> > 
>> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
>> >   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
>> > 
>> > ----------------------------------------------------------------
>> > 
>> > Sebastien Helleu (1):
>> >       l10n: fr.po: hotfix for commit 6b388fc
>> 
>> Hmph, what happened that requires a "hotfix" to message strings?
>
> Well, as the author of the first commit,, I must say that the quality was not 
> good. But it became visible and hooked up a reviewer only when it was promoted 
> to stable version...
>
> There are some strings that do not make sense in the usage pages, a missing %s 
> in one.  	Agreed that applying this patch does not solve a critical issue, but 
> it is low risk.

OK, I was just reacting to the "hotfix" wording and wondering the level of urgency. Will pull to maint later before cutting 1.8.4.1.

Thanks.

Show 9 quoted lines

>
>> 
>> >  po/TEAMS |    1 +
>> >  po/fr.po | 1591
>> >  ++++++++++++++++++++++++++++++++++---------------------------- 2 files
>> >  changed, 874 insertions(+), 718 deletions(-)
>> > 
>> > --
>> > Jiang Xin