Re: [GIT PULL] hotfix on fr.po for the maint branch

From: Jean-Noël AVILA <jn.avila@free.fr>
Date: Aug 30, 2013, 17:23 UTC
Message-ID: <21533323.C8UgJI1nMs@cayenne>
In-Reply-To: <xmqq61un15lo.fsf@gitster.dls.corp.google.com>

Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :

> Jiang Xin <worldhello.net@gmail.com> writes:
> > Please merge this commit to the maint branch.
> > 
> > The following changes since commit

e230c568c4b9a991e3175e5f65171a566fd8e39c:

Show 14 quoted lines

> >   Git 1.8.4 (2013-08-23 11:49:46 -0700)
> > 
> > are available in the git repository at:
> >   git://github.com/git-l10n/git-po master
> > 
> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
> >   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
> > 
> > ----------------------------------------------------------------
> > 
> > Sebastien Helleu (1):
> >       l10n: fr.po: hotfix for commit 6b388fc
> 
> Hmph, what happened that requires a "hotfix" to message strings?

Well, as the author of the first commit,, I must say that the quality was not good. But it became visible and hooked up a reviewer only when it was promoted to stable version...

There are some strings that do not make sense in the usage pages, a missing %s in one. Agreed that applying this patch does not solve a critical issue, but it is low risk.

Show 8 quoted lines

> 
> >  po/TEAMS |    1 +
> >  po/fr.po | 1591
> >  ++++++++++++++++++++++++++++++++++---------------------------- 2 files
> >  changed, 874 insertions(+), 718 deletions(-)
> > 
> > --
> > Jiang Xin