{"thread":{"id":"34807","subject":"[GIT PULL] hotfix on fr.po for the maint branch","startedAt":"2013-08-30T09:07:26Z","lastAt":"2013-08-30T18:07:06Z","messageCount":4,"participants":["Jiang Xin","Junio C Hamano","Jean-Noël AVILA"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"226334","messageId":"CANYiYbG6MweCwLaUw5Uk3S9a0hUY1vuS+ORCF1BipkZkJeHjrw@mail.gmail.com","threadId":"34807","inReplyTo":null,"subject":"[GIT PULL] hotfix on fr.po for the maint branch","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2013-08-30T09:07:26Z","receivedAt":"2013-08-30T09:07:26Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"Hi, Junio\n\nPlease merge this commit to the maint branch.\n\nThe following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:\n\n  Git 1.8.4 (2013-08-23 11:49:46 -0700)\n\nare available in the git repository at:\n\n  git://github.com/git-l10n/git-po master\n\nfor you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:\n\n  l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)\n\n----------------------------------------------------------------\nSebastien Helleu (1):\n      l10n: fr.po: hotfix for commit 6b388fc\n\n po/TEAMS |    1 +\n po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------\n 2 files changed, 874 insertions(+), 718 deletions(-)\n\n--\nJiang Xin\n"},{"id":"226344","messageId":"xmqq61un15lo.fsf@gitster.dls.corp.google.com","threadId":"34807","inReplyTo":"CANYiYbG6MweCwLaUw5Uk3S9a0hUY1vuS+ORCF1BipkZkJeHjrw@mail.gmail.com","subject":"Re: [GIT PULL] hotfix on fr.po for the maint branch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-30T16:54:59Z","receivedAt":"2013-08-30T16:54:59Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jiang Xin <worldhello.net@gmail.com> writes:\n\n> Please merge this commit to the maint branch.\n>\n> The following changes since commit e230c568c4b9a991e3175e5f65171a566fd8e39c:\n>\n>   Git 1.8.4 (2013-08-23 11:49:46 -0700)\n>\n> are available in the git repository at:\n>\n>   git://github.com/git-l10n/git-po master\n>\n> for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:\n>\n>   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)\n>\n> ----------------------------------------------------------------\n> Sebastien Helleu (1):\n>       l10n: fr.po: hotfix for commit 6b388fc\n\nHmph, what happened that requires a \"hotfix\" to message strings?\n\n>\n>  po/TEAMS |    1 +\n>  po/fr.po | 1591 ++++++++++++++++++++++++++++++++++----------------------------\n>  2 files changed, 874 insertions(+), 718 deletions(-)\n>\n> --\n> Jiang Xin\n"},{"id":"226346","messageId":"21533323.C8UgJI1nMs@cayenne","threadId":"34807","inReplyTo":"xmqq61un15lo.fsf@gitster.dls.corp.google.com","subject":"Re: [GIT PULL] hotfix on fr.po for the maint branch","fromName":"Jean-Noël AVILA","fromEmail":"jn.avila@free.fr","sentAt":"2013-08-30T17:23:54Z","receivedAt":"2013-08-30T17:23:54Z","isPatch":false,"sender":{"key":"jn.avila@free.fr","avatar":"https://avatars.githubusercontent.com/u/156172?v=4"},"body":"Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :\n> Jiang Xin <worldhello.net@gmail.com> writes:\n> > Please merge this commit to the maint branch.\n> > \n> > The following changes since commit \ne230c568c4b9a991e3175e5f65171a566fd8e39c:\n> >   Git 1.8.4 (2013-08-23 11:49:46 -0700)\n> > \n> > are available in the git repository at:\n> >   git://github.com/git-l10n/git-po master\n> > \n> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:\n> >   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)\n> > \n> > ----------------------------------------------------------------\n> > \n> > Sebastien Helleu (1):\n> >       l10n: fr.po: hotfix for commit 6b388fc\n> \n> Hmph, what happened that requires a \"hotfix\" to message strings?\n\nWell, as the author of the first commit,, I must say that the quality was not \ngood. But it became visible and hooked up a reviewer only when it was promoted \nto stable version...\n\nThere are some strings that do not make sense in the usage pages, a missing %s \nin one.  \tAgreed that applying this patch does not solve a critical issue, but \nit is low risk.\n\n> \n> >  po/TEAMS |    1 +\n> >  po/fr.po | 1591\n> >  ++++++++++++++++++++++++++++++++++---------------------------- 2 files\n> >  changed, 874 insertions(+), 718 deletions(-)\n> > \n> > --\n> > Jiang Xin\n"},{"id":"226348","messageId":"xmqqli3jyrw5.fsf@gitster.dls.corp.google.com","threadId":"34807","inReplyTo":"21533323.C8UgJI1nMs@cayenne","subject":"Re: [GIT PULL] hotfix on fr.po for the maint branch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-30T18:07:06Z","receivedAt":"2013-08-30T18:07:06Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jean-Noël AVILA <jn.avila@free.fr> writes:\n\n> Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :\n>> Jiang Xin <worldhello.net@gmail.com> writes:\n>> > Please merge this commit to the maint branch.\n>> > \n>> > The following changes since commit \n> e230c568c4b9a991e3175e5f65171a566fd8e39c:\n>> >   Git 1.8.4 (2013-08-23 11:49:46 -0700)\n>> > \n>> > are available in the git repository at:\n>> >   git://github.com/git-l10n/git-po master\n>> > \n>> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:\n>> >   l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)\n>> > \n>> > ----------------------------------------------------------------\n>> > \n>> > Sebastien Helleu (1):\n>> >       l10n: fr.po: hotfix for commit 6b388fc\n>> \n>> Hmph, what happened that requires a \"hotfix\" to message strings?\n>\n> Well, as the author of the first commit,, I must say that the quality was not \n> good. But it became visible and hooked up a reviewer only when it was promoted \n> to stable version...\n>\n> There are some strings that do not make sense in the usage pages, a missing %s \n> in one.  \tAgreed that applying this patch does not solve a critical issue, but \n> it is low risk.\n\nOK, I was just reacting to the \"hotfix\" wording and wondering the\nlevel of urgency.  Will pull to maint later before cutting 1.8.4.1.\n\nThanks.\n\n>\n>> \n>> >  po/TEAMS |    1 +\n>> >  po/fr.po | 1591\n>> >  ++++++++++++++++++++++++++++++++++---------------------------- 2 files\n>> >  changed, 874 insertions(+), 718 deletions(-)\n>> > \n>> > --\n>> > Jiang Xin\n"}]}