threads / patch / 34314

patchlib-rebase: document exec_ in FAKE_LINES

Subject: [PATCH] lib-rebase: document exec_ in FAKE_LINES

## tl;dr

4 messages between Jul 1, 2013 and Jul 1, 2013. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Andrew Pimlott· Jul 1, 2013, 16:20 UTC · lore

Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
---
 t/lib-rebase.sh |    2 ++
 1 file changed, 2 insertions(+)

Show changes to t/lib-rebase.sh +2 −0

diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh
index cfd3409..7f119e2 100644
--- a/t/lib-rebase.sh
+++ b/t/lib-rebase.sh
@@ -17,6 +17,8 @@
 #       ("squash", "fixup", "edit", or "reword") and the SHA1 taken
 #       from the specified line.
 #
+#   "exec_cmd_with_args" -- add an "exec cmd with args" line.
+#
 #   "#" -- Add a comment line.
 #
 #   ">" -- Add a blank line.

-- 
1.7.10.4

Andrew Pimlott· Jul 1, 2013, 16:20 UTC · re: Andrew Pimlott · lore

[PATCH] t7500: fix flipped actual/expect

Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
---
 t/t7500-commit.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to t/t7500-commit.sh +2 −2

diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
index 436b7b6..e166ac8 100755
--- a/t/t7500-commit.sh
+++ b/t/t7500-commit.sh
@@ -13,8 +13,8 @@ commit_msg_is () {
 	expect=commit_msg_is.expect
 	actual=commit_msg_is.actual
 
-	printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect &&
-	printf "%s" "$1" >$actual &&
+	printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual &&
+	printf "%s" "$1" >$expect &&
 	test_i18ncmp $expect $actual
 }

-- 
1.7.10.4

Junio C Hamano· Jul 1, 2013, 16:52 UTC · re: Andrew Pimlott · lore

Re: [PATCH] t7500: fix flipped actual/expect

Andrew Pimlott <andrew@pimlott.net> writes:

Show 19 quoted lines

> Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
> ---
>  t/t7500-commit.sh |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
> index 436b7b6..e166ac8 100755
> --- a/t/t7500-commit.sh
> +++ b/t/t7500-commit.sh
> @@ -13,8 +13,8 @@ commit_msg_is () {
>  	expect=commit_msg_is.expect
>  	actual=commit_msg_is.actual
>  
> -	printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect &&
> -	printf "%s" "$1" >$actual &&
> +	printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual &&
> +	printf "%s" "$1" >$expect &&
>  	test_i18ncmp $expect $actual
>  }

Wow.  How could all of us missed this for a long time?

Thanks, the change obviously looks good.

Andrew Pimlott· Jul 1, 2013, 17:07 UTC · re: Junio C Hamano · lore

Re: [PATCH] t7500: fix flipped actual/expect

Excerpts from Junio C Hamano's message of Mon Jul 01 09:52:05 -0700 2013:

> Wow.  How could all of us missed this for a long time?

:-) I don't know, but little is more frustrating than a misleading diagnostic.

BTW, I didn't expect git-send-email to send those two messages in a thread. I'll keep them separate next time.

Andrew