# [PATCH] lib-rebase: document exec_ in FAKE_LINES 4 messages from 2013-07-01 to 2013-07-01. Participants: Andrew Pimlott, Junio C Hamano. Thread: https://gitlist.dev/t/34314 ## Andrew Pimlott, 2013-07-01 16:20 Subject: [PATCH] lib-rebase: document exec_ in FAKE_LINES Message-ID: <1372695636-10768-1-git-send-email-andrew@pimlott.net> URL: https://gitlist.dev/e/1372695636-10768-1-git-send-email-andrew%40pimlott.net ``` Signed-off-by: Andrew Pimlott --- t/lib-rebase.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh index cfd3409..7f119e2 100644 --- a/t/lib-rebase.sh +++ b/t/lib-rebase.sh @@ -17,6 +17,8 @@ # ("squash", "fixup", "edit", or "reword") and the SHA1 taken # from the specified line. # +# "exec_cmd_with_args" -- add an "exec cmd with args" line. +# # "#" -- Add a comment line. # # ">" -- Add a blank line. -- 1.7.10.4 ``` ## Andrew Pimlott, 2013-07-01 16:20 Subject: [PATCH] t7500: fix flipped actual/expect Message-ID: <1372695636-10768-2-git-send-email-andrew@pimlott.net> URL: https://gitlist.dev/e/1372695636-10768-2-git-send-email-andrew%40pimlott.net In-Reply-To: <1372695636-10768-1-git-send-email-andrew@pimlott.net> ``` Signed-off-by: Andrew Pimlott --- t/t7500-commit.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh index 436b7b6..e166ac8 100755 --- a/t/t7500-commit.sh +++ b/t/t7500-commit.sh @@ -13,8 +13,8 @@ commit_msg_is () { expect=commit_msg_is.expect actual=commit_msg_is.actual - printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect && - printf "%s" "$1" >$actual && + printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual && + printf "%s" "$1" >$expect && test_i18ncmp $expect $actual } -- 1.7.10.4 ``` ## Junio C Hamano, 2013-07-01 16:52 Subject: Re: [PATCH] t7500: fix flipped actual/expect Message-ID: <7vwqpagr4a.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwqpagr4a.fsf%40alter.siamese.dyndns.org In-Reply-To: <1372695636-10768-2-git-send-email-andrew@pimlott.net> ``` Andrew Pimlott writes: > Signed-off-by: Andrew Pimlott > --- > t/t7500-commit.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh > index 436b7b6..e166ac8 100755 > --- a/t/t7500-commit.sh > +++ b/t/t7500-commit.sh > @@ -13,8 +13,8 @@ commit_msg_is () { > expect=commit_msg_is.expect > actual=commit_msg_is.actual > > - printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect && > - printf "%s" "$1" >$actual && > + printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual && > + printf "%s" "$1" >$expect && > test_i18ncmp $expect $actual > } Wow. How could all of us missed this for a long time? Thanks, the change obviously looks good. ``` ## Andrew Pimlott, 2013-07-01 17:07 Subject: Re: [PATCH] t7500: fix flipped actual/expect Message-ID: <1372698093-sup-9117@pimlott.net> URL: https://gitlist.dev/e/1372698093-sup-9117%40pimlott.net In-Reply-To: <7vwqpagr4a.fsf@alter.siamese.dyndns.org> ``` Excerpts from Junio C Hamano's message of Mon Jul 01 09:52:05 -0700 2013: > Wow. How could all of us missed this for a long time? :-) I don't know, but little is more frustrating than a misleading diagnostic. BTW, I didn't expect git-send-email to send those two messages in a thread. I'll keep them separate next time. Andrew ```