threads / patch / 34269

patchstage: remove unused, unreferenced builtin-alias

Subject: [PATCH] stage: remove unused, unreferenced builtin-alias

## tl;dr

4 messages between Jun 24, 2013 and Jun 24, 2013. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Ramkumar Ramachandra· Jun 24, 2013, 18:12 UTC · lore

11920d2 (Add a built-in alias for 'stage' to the 'add' command, 2008-12-01) added a the 'git stage' command which simply calls cmd_add(). Since then, no references to it have been made anywhere on the internet; there is no evidence that anyone even knows about its existence. It is a long-lost forgotten command that only serves the purpose of preventing the user from having a custom alias.stage to do something useful. Remove it.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 I just found out about its existence.

 Documentation/git-stage.txt | 23 -----------------------
 Makefile                    |  3 +--
 git.c                       |  1 -
 3 files changed, 1 insertion(+), 26 deletions(-)
 delete mode 100644 Documentation/git-stage.txt

Show changes to 3 files +1 −22

Documentation/git-stage.txt, Makefile, git.c

diff --git a/Documentation/git-stage.txt b/Documentation/git-stage.txt
deleted file mode 100644
index ba3fe0d..0000000
--- a/Documentation/git-stage.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-git-stage(1)
-==============
-
-NAME
-----
-git-stage - Add file contents to the staging area
-
-
-SYNOPSIS
---------
-[verse]
-'git stage' args...
-
-
-DESCRIPTION
------------
-
-This is a synonym for linkgit:git-add[1].  Please refer to the
-documentation of that command.
-
-GIT
----
-Part of the linkgit:git[1] suite
diff --git a/Makefile b/Makefile
index 79f961e..33ea9df 100644
--- a/Makefile
+++ b/Makefile
@@ -597,7 +597,6 @@ BUILT_INS += git-merge-subtree$X
 BUILT_INS += git-peek-remote$X
 BUILT_INS += git-repo-config$X
 BUILT_INS += git-show$X
-BUILT_INS += git-stage$X
 BUILT_INS += git-status$X
 BUILT_INS += git-whatchanged$X
 
@@ -2527,7 +2526,7 @@ check-docs::
 		git-merge-octopus | git-merge-ours | git-merge-recursive | \
 		git-merge-resolve | git-merge-subtree | \
 		git-fsck-objects | git-init-db | \
-		git-remote-* | git-stage | \
+		git-remote-* | \
 		git-?*--?* ) continue ;; \
 		esac ; \
 		test -f "Documentation/$$v.txt" || \
diff --git a/git.c b/git.c
index 4359086..38bffdb 100644
--- a/git.c
+++ b/git.c
@@ -408,7 +408,6 @@ static void handle_internal_command(int argc, const char **argv)
 		{ "show", cmd_show, RUN_SETUP },
 		{ "show-branch", cmd_show_branch, RUN_SETUP },
 		{ "show-ref", cmd_show_ref, RUN_SETUP },
-		{ "stage", cmd_add, RUN_SETUP | NEED_WORK_TREE },
 		{ "status", cmd_status, RUN_SETUP | NEED_WORK_TREE },
 		{ "stripspace", cmd_stripspace },
 		{ "symbolic-ref", cmd_symbolic_ref, RUN_SETUP },

-- 
1.8.3.1.550.g54d55ef

Matthieu Moy· Jun 24, 2013, 18:27 UTC · re: Ramkumar Ramachandra · lore

Re: [PATCH] stage: remove unused, unreferenced builtin-alias

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,
> 2008-12-01) added a the 'git stage' command which simply calls
> cmd_add().  Since then, no references to it have been made anywhere on
> the internet;

$ git sta<TAB> stage stash status

So the command is discoverable.

Also, googling a bit gives me this:

  http://git-scm.com/docs/git-stage

It's not particularly visible, but it's discoverable.

> there is no evidence that anyone even knows about its existence.

I did :-\.

I can very well live without it, but the few people like me who sometimes run "git stage" would be surprised if it stopped working without a deprecation period.

(In my case, I read the thread so it's OK, but there may be others)

>  Documentation/git-stage.txt | 23 -----------------------
>  Makefile                    |  3 +--
>  git.c                       |  1 -

If you go for it, there's also the completion script:

_git_stage ()
{
	_git_add
}

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Junio C Hamano· Jun 24, 2013, 18:27 UTC · re: Ramkumar Ramachandra · lore

Re: [PATCH] stage: remove unused, unreferenced builtin-alias

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 11 quoted lines

> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,
> 2008-12-01) added a the 'git stage' command which simply calls
> cmd_add().  Since then, no references to it have been made anywhere on
> the internet; there is no evidence that anyone even knows about its
> existence.  It is a long-lost forgotten command that only serves the
> purpose of preventing the user from having a custom alias.stage to do
> something useful.  Remove it.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  I just found out about its existence.

Hmm, this has not discussed on the list at all, let alone achieving consensus that it is a good change.

At least, please direct the patch Cc'ed to the original author of what you are removing, not to me.

Thanks.

Ramkumar Ramachandra· Jun 24, 2013, 18:48 UTC · re: Ramkumar Ramachandra · lore

Re: [PATCH] stage: remove unused, unreferenced builtin-alias

Ramkumar Ramachandra wrote:

Show 11 quoted lines

> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,
> 2008-12-01) added a the 'git stage' command which simply calls
> cmd_add().  Since then, no references to it have been made anywhere on
> the internet; there is no evidence that anyone even knows about its
> existence.  It is a long-lost forgotten command that only serves the
> purpose of preventing the user from having a custom alias.stage to do
> something useful.  Remove it.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  I just found out about its existence.

Should we plan a deprecation (2.0 perhaps)?