Re: [PATCH] stage: remove unused, unreferenced builtin-alias

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 24, 2013, 18:27 UTC
Message-ID: <vpqobavnz3x.fsf@anie.imag.fr>
In-Reply-To: <1372097546-27721-1-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,
> 2008-12-01) added a the 'git stage' command which simply calls
> cmd_add().  Since then, no references to it have been made anywhere on
> the internet;

$ git sta<TAB> stage stash status

So the command is discoverable.

Also, googling a bit gives me this:

  http://git-scm.com/docs/git-stage

It's not particularly visible, but it's discoverable.

> there is no evidence that anyone even knows about its existence.

I did :-\.

I can very well live without it, but the few people like me who sometimes run "git stage" would be surprised if it stopped working without a deprecation period.

(In my case, I read the thread so it's OK, but there may be others)

>  Documentation/git-stage.txt | 23 -----------------------
>  Makefile                    |  3 +--
>  git.c                       |  1 -

If you go for it, there's also the completion script:

_git_stage ()
{
	_git_add
}

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/