{"thread":{"id":"34269","subject":"[PATCH] stage: remove unused, unreferenced builtin-alias","startedAt":"2013-06-24T18:12:26Z","lastAt":"2013-06-24T18:48:29Z","messageCount":4,"participants":["Ramkumar Ramachandra","Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"221866","messageId":"1372097546-27721-1-git-send-email-artagnon@gmail.com","threadId":"34269","inReplyTo":null,"subject":"[PATCH] stage: remove unused, unreferenced builtin-alias","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-24T18:12:26Z","receivedAt":"2013-06-24T18:12:26Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"11920d2 (Add a built-in alias for 'stage' to the 'add' command,\n2008-12-01) added a the 'git stage' command which simply calls\ncmd_add(). Since then, no references to it have been made anywhere on\nthe internet; there is no evidence that anyone even knows about its\nexistence. It is a long-lost forgotten command that only serves the\npurpose of preventing the user from having a custom alias.stage to do\nsomething useful. Remove it.\n\nSigned-off-by: Ramkumar Ramachandra \n---\n I just found out about its existence.\n\n Documentation/git-stage.txt | 23 -----------------------\n Makefile | 3 +--\n git.c | 1 -\n 3 files changed, 1 insertion(+), 26 deletions(-)\n delete mode 100644 Documentation/git-stage.txt\n\ndiff --git a/Documentation/git-stage.txt b/Documentation/git-stage.txt\ndeleted file mode 100644\nindex ba3fe0d..0000000\n--- a/Documentation/git-stage.txt\n+++ /dev/null\n@@ -1,23 +0,0 @@\n-git-stage(1)\n-==============\n-\n-NAME\n-----\n-git-stage - Add file contents to the staging area\n-\n-\n-SYNOPSIS\n---------\n-[verse]\n-'git stage' args...\n-\n-\n-DESCRIPTION\n------------\n-\n-This is a synonym for linkgit:git-add[1]. Please refer to the\n-documentation of that command.\n-\n-GIT\n----\n-Part of the linkgit:git[1] suite\ndiff --git a/Makefile b/Makefile\nindex 79f961e..33ea9df 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -597,7 +597,6 @@ BUILT_INS += git-merge-subtree$X\n BUILT_INS += git-peek-remote$X\n BUILT_INS += git-repo-config$X\n BUILT_INS += git-show$X\n-BUILT_INS += git-stage$X\n BUILT_INS += git-status$X\n BUILT_INS += git-whatchanged$X\n \n@@ -2527,7 +2526,7 @@ check-docs::\n \t\tgit-merge-octopus | git-merge-ours | git-merge-recursive | \\\n \t\tgit-merge-resolve | git-merge-subtree | \\\n \t\tgit-fsck-objects | git-init-db | \\\n-\t\tgit-remote-* | git-stage | \\\n+\t\tgit-remote-* | \\\n \t\tgit-?*--?* ) continue ;; \\\n \t\tesac ; \\\n \t\ttest -f \"Documentation/$$v.txt\" || \\\ndiff --git a/git.c b/git.c\nindex 4359086..38bffdb 100644\n--- a/git.c\n+++ b/git.c\n@@ -408,7 +408,6 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"show\", cmd_show, RUN_SETUP },\n \t\t{ \"show-branch\", cmd_show_branch, RUN_SETUP },\n \t\t{ \"show-ref\", cmd_show_ref, RUN_SETUP },\n-\t\t{ \"stage\", cmd_add, RUN_SETUP | NEED_WORK_TREE },\n \t\t{ \"status\", cmd_status, RUN_SETUP | NEED_WORK_TREE },\n \t\t{ \"stripspace\", cmd_stripspace },\n \t\t{ \"symbolic-ref\", cmd_symbolic_ref, RUN_SETUP },\n-- \n1.8.3.1.550.g54d55ef\n"},{"id":"221872","messageId":"vpqobavnz3x.fsf@anie.imag.fr","threadId":"34269","inReplyTo":"1372097546-27721-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] stage: remove unused, unreferenced builtin-alias","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2013-06-24T18:27:14Z","receivedAt":"2013-06-24T18:27:14Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Ramkumar Ramachandra writes:\n\n> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,\n> 2008-12-01) added a the 'git stage' command which simply calls\n> cmd_add(). Since then, no references to it have been made anywhere on\n> the internet; \n\n$ git sta\nstage stash status \n\nSo the command is discoverable.\n\nAlso, googling a bit gives me this:\n\n http://git-scm.com/docs/git-stage\n\nIt's not particularly visible, but it's discoverable.\n\n> there is no evidence that anyone even knows about its existence.\n\nI did :-\\.\n\nI can very well live without it, but the few people like me who\nsometimes run \"git stage\" would be surprised if it stopped working\nwithout a deprecation period.\n\n(In my case, I read the thread so it's OK, but there may be others)\n\n> Documentation/git-stage.txt | 23 -----------------------\n> Makefile | 3 +--\n> git.c | 1 -\n\nIf you go for it, there's also the completion script:\n\n_git_stage ()\n{\n\t_git_add\n}\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"221873","messageId":"7vvc538iu0.fsf@alter.siamese.dyndns.org","threadId":"34269","inReplyTo":"1372097546-27721-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] stage: remove unused, unreferenced builtin-alias","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-06-24T18:27:51Z","receivedAt":"2013-06-24T18:27:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramkumar Ramachandra writes:\n\n> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,\n> 2008-12-01) added a the 'git stage' command which simply calls\n> cmd_add(). Since then, no references to it have been made anywhere on\n> the internet; there is no evidence that anyone even knows about its\n> existence. It is a long-lost forgotten command that only serves the\n> purpose of preventing the user from having a custom alias.stage to do\n> something useful. Remove it.\n>\n> Signed-off-by: Ramkumar Ramachandra \n> ---\n> I just found out about its existence.\n\nHmm, this has not discussed on the list at all, let alone achieving\nconsensus that it is a good change.\n\nAt least, please direct the patch Cc'ed to the original author of\nwhat you are removing, not to me.\n\nThanks.\n"},{"id":"221876","messageId":"CALkWK0nRLMby4A4A8YwkCp2Q8cpBdW3XWPRwt0fnE=8iHX3Tcw@mail.gmail.com","threadId":"34269","inReplyTo":"1372097546-27721-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] stage: remove unused, unreferenced builtin-alias","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-24T18:48:29Z","receivedAt":"2013-06-24T18:48:29Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Ramkumar Ramachandra wrote:\n> 11920d2 (Add a built-in alias for 'stage' to the 'add' command,\n> 2008-12-01) added a the 'git stage' command which simply calls\n> cmd_add(). Since then, no references to it have been made anywhere on\n> the internet; there is no evidence that anyone even knows about its\n> existence. It is a long-lost forgotten command that only serves the\n> purpose of preventing the user from having a custom alias.stage to do\n> something useful. Remove it.\n>\n> Signed-off-by: Ramkumar Ramachandra \n> ---\n> I just found out about its existence.\n\nShould we plan a deprecation (2.0 perhaps)?\n"}]}