patch, 2 partsRe: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default

<y@ensimag.imag.fr> wrote:

Good change.

I expected one test. Two, at most. This is a bit overzealous. I don't mind leaving it as it is, but as a note for the future: this kind of overkill is not necessarily a good thing; it makes it hard to add/remove tests, multiple tests fail when one tiny feature doesn't work as expected, and the testsuite takes longer to run.

Ramkumar Ramachandra <artagnon@gmail.com> writes:

I actually had this discussion with Jorge (in real life). I first thought this was too much, and I think we already removed one rendundant test. But actually, this should be "two at least", since you really want to test whether --[no-]branch takes precedence over status.branch or not, in addition to testing status.branch alone.

The last two tests are less important, but they also test something (in short: what happens when branch.status is set to something other than "true"). So I think it makes sense to keep them.