{"thread":{"id":"34099","subject":"Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default","startedAt":"2013-06-11T07:30:45Z","lastAt":"2013-06-11T07:51:58Z","messageCount":2,"participants":["Ramkumar Ramachandra","Matthieu Moy"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"220417","messageId":"CALkWK0mQ9e1nR1jBgZKB6hgV+ptEXr225MchsVoM6514-KdqPg@mail.gmail.com","threadId":"34099","inReplyTo":"51b5ede3.41a42a0a.02a1.3464SMTPIN_ADDED_BROKEN@mx.google.com","subject":"Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-11T07:30:45Z","receivedAt":"2013-06-11T07:30:45Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"<y@ensimag.imag.fr> wrote:\n> [...]\n\nGood change.\n\n> diff --git a/t/t7508-status.sh b/t/t7508-status.sh\n> index 9a07f15..958617a 100755\n> --- a/t/t7508-status.sh\n> +++ b/t/t7508-status.sh\n\nI expected one test.  Two, at most.  This is a bit overzealous.  I\ndon't mind leaving it as it is, but as a note for the future: this\nkind of overkill is not necessarily a good thing; it makes it hard to\nadd/remove tests, multiple tests fail when one tiny feature doesn't\nwork as expected, and the testsuite takes longer to run.\n"},{"id":"220418","messageId":"vpqy5ah84pt.fsf@anie.imag.fr","threadId":"34099","inReplyTo":"CALkWK0mQ9e1nR1jBgZKB6hgV+ptEXr225MchsVoM6514-KdqPg@mail.gmail.com","subject":"Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2013-06-11T07:51:58Z","receivedAt":"2013-06-11T07:51:58Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Ramkumar Ramachandra <artagnon@gmail.com> writes:\n\n> <y@ensimag.imag.fr> wrote:\n>> [...]\n>\n> Good change.\n>\n>> diff --git a/t/t7508-status.sh b/t/t7508-status.sh\n>> index 9a07f15..958617a 100755\n>> --- a/t/t7508-status.sh\n>> +++ b/t/t7508-status.sh\n>\n> I expected one test.  Two, at most.  This is a bit overzealous. \n\nI actually had this discussion with Jorge (in real life). I first\nthought this was too much, and I think we already removed one rendundant\ntest. But actually, this should be \"two at least\", since you really want\nto test whether --[no-]branch takes precedence over status.branch or\nnot, in addition to testing status.branch alone.\n\nThe last two tests are less important, but they also test something (in\nshort: what happens when branch.status is set to something other than\n\"true\"). So I think it makes sense to keep them.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}