Re: v3 [PATCH 2/2] status:introduce status.branch to enable --branch by default
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 11, 2013, 07:30 UTC
- Message-ID
- <CALkWK0mQ9e1nR1jBgZKB6hgV+ptEXr225MchsVoM6514-KdqPg@mail.gmail.com>
- In-Reply-To
- <51b5ede3.41a42a0a.02a1.3464SMTPIN_ADDED_BROKEN@mx.google.com>
<y@ensimag.imag.fr> wrote:
> [...]
Good change.
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh > index 9a07f15..958617a 100755 > --- a/t/t7508-status.sh > +++ b/t/t7508-status.sh
I expected one test. Two, at most. This is a bit overzealous. I don't mind leaving it as it is, but as a note for the future: this kind of overkill is not necessarily a good thing; it makes it hard to add/remove tests, multiple tests fail when one tiny feature doesn't work as expected, and the testsuite takes longer to run.